improved tcp closure #2344
Merged
improved tcp closure #2344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaprile
requested changes
Aug 15, 2023
b19a044 to
4e9073c
Compare
scaprile
reviewed
Aug 17, 2023
scaprile
reviewed
Aug 17, 2023
4e9073c to
4d7f80e
Compare
scaprile
approved these changes
Aug 17, 2023
test/mip_tap_test.c
Outdated
| } | ||
|
|
||
| // Clear | ||
| usleep(1000000); // Waiting until all connections finally close |
There was a problem hiding this comment.
How can this happen without us calling the manager ?
There was a problem hiding this comment.
We call the manager before in the fetch function when we initiate the TCP closure and start the timeout for the connection to be deleted. Therefore, before calling the manager at the end we have to wait this maximum amount of time until we are sure all the connections are freed.
4d7f80e to
3104ba4
Compare
3104ba4 to
f5e87cc
Compare
cpq
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.