including winsock2.h if ipv6 enabled #626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rojer
pushed a commit
that referenced
this pull request
Mar 15, 2016
Contributed by @f4bsch in #626 Submitting here with a minor change: MSDN says that ws2ipdef.h should not be included directly and users should include ws2tcpip.h PUBLISHED_FROM=1ebe7eac0cf87b0554432b94049b3d58bf7640f7
|
committed in 1d0a898, thanks |
mkmik
pushed a commit
to cesanta/mongoose-os
that referenced
this pull request
Mar 15, 2016
Contributed by @f4bsch in cesanta/mongoose#626 Submitting here with a minor change: MSDN says that ws2ipdef.h should not be included directly and users should include ws2tcpip.h PUBLISHED_FROM=1ebe7eac0cf87b0554432b94049b3d58bf7640f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default windows.h loads
winsock.h, notWinSock2.h. The latter is required (plusWs2ipdef.h) for IPv6 support.Also note that in the mongoose.h there is a pragma comment to link with Winsock2 lib, but mongoose actually uses the Winsock1 headers.