Skip to content

Mark ready as async #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2025
Merged

Mark ready as async #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/centrifuge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,13 +207,13 @@ export class Centrifuge extends (EventEmitter as new () => TypedEventEmitter<Cli
/** ready returns a Promise which resolves upon client goes to Connected
* state and rejects in case of client goes to Disconnected or Failed state.
* Users can provide optional timeout in milliseconds. */
ready(timeout?: number): Promise<void> {
async ready(timeout?: number): Promise<void> {
switch (this.state) {
case State.Disconnected:
return Promise.reject({ code: errorCodes.clientDisconnected, message: 'client disconnected' });
throw { code: errorCodes.clientDisconnected, message: 'client disconnected' };

case State.Connected:
return Promise.resolve();
return;

default:
return new Promise((resolve, reject) => {
Expand Down Expand Up @@ -1658,7 +1658,7 @@ export class Centrifuge extends (EventEmitter as new () => TypedEventEmitter<Cli
next();
return;
}
const error = {code: reply.error.code, message: reply.error.message || '', temporary: reply.error.temporary || false}
const error = {code: reply.error.code, message: reply.error.message || '', temporary: reply.error.temporary || false};
errback({ error, next });
}
}
Expand Down