This repository was archived by the owner on Oct 24, 2022. It is now read-only.
Webrtcsink encoder setup #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Update README
5d77ad2 to
442f9fd
Compare
sdroege
reviewed
Mar 25, 2022
| String::static_type().into(), | ||
| gst::Element::static_type().into(), | ||
| ], | ||
| bool::static_type().into(), |
There was a problem hiding this comment.
You probably want to
- Use an accumulator function that causes the next handler to not be called anymore if
false(ortrue, your decision) is returned - Have a default class handler that does the default setup (i.e. the
configure_encoder()function)
That way applications can connect signal handlers before or after the class handler, and can decide if they just want to extend the behaviour or don't want the class handler to be called. Just like many such signals work in GTK for example.
sdroege
reviewed
Mar 25, 2022
| false, | ||
| )?; | ||
|
|
||
| let encoder_was_configured: bool = element.emit_by_name( |
There was a problem hiding this comment.
element.emit_by_name::<bool>(...) is what is generally used
sdroege
reviewed
Mar 25, 2022
|
|
||
| info!("Encoder: {}", encoder.factory().unwrap().name()); | ||
|
|
||
| let configured = match encoder.factory().unwrap().name().as_str() { |
There was a problem hiding this comment.
You maybe want to get the factory (name) only once here, and also not panic if the element has no factory
sdroege
reviewed
Mar 25, 2022
| .by_name("ws") | ||
| .unwrap(); | ||
|
|
||
| ws.connect("encoder-setup", false, |values| { |
There was a problem hiding this comment.
This false here makes it connect before the class handler btw, a true would be after.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.