This repository was archived by the owner on Oct 24, 2022. It is now read-only.
signalling: fix -h flag parsing #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sounds great. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like after recent
clapupdate, it now panics (at least in debug) due to non-unique arguments (-hcomes by bothhostandhelp).-hfor help seems to be more reasonable imo, so I suggest to remove short flag for host. Or we can make it different. Please suggest if you have better idea.$ cargo run --bin server Finished dev [unoptimized + debuginfo] target(s) in 0.24s Running `target/debug/server` thread 'main' panicked at 'Command webrtcsink-signalling: Short option names must be unique for each argument, but '-h' is in use by both 'host' and 'help' (call `cmd.disable_help_flag(true)` to remove the auto-generated `--help`)', /Users/nazar/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-4.0.16/src/builder/debug_asserts.rs:121:17 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace