Skip to content
This repository was archived by the owner on Oct 24, 2022. It is now read-only.

Conversation

thiblahute
Copy link
Contributor

We can't do much about it at this point

Fixes #110

@MathieuDuponchelle
Copy link
Collaborator

The only reason pause_task can return False is when the pad had no task apparently, how can this be happening?

@MathieuDuponchelle
Copy link
Collaborator

Also I notice that we might pause while holding the state lock, that's not ideal (and something I fixed in mccparse / sccparse some time ago)

@MathieuDuponchelle
Copy link
Collaborator

2131d5bfda964a062127ed859ce8d28e17f0e450 in gst-plugins-rs fwiw

@MathieuDuponchelle
Copy link
Collaborator

scratch that last remark, I think we always release actually :)

@thiblahute
Copy link
Contributor Author

The only reason pause_task can return False is when the pad had no task apparently, how can this be happening?

From the stack trace this happened when pushing the buffer list failed, I guess the task is already stopped from some other code path and is being joined?

@MathieuDuponchelle
Copy link
Collaborator

I see, then let's just ignore altogether and not log an error :)

@thiblahute
Copy link
Contributor Author

I see, then let's just ignore altogether and not log an error :)

Indeed, an debug maybe still?

@MathieuDuponchelle
Copy link
Collaborator

elsewhere in gst-plugins-rs we just let _ = pause_task, let's just do the same here :)

We can't do much about it at this point

Fixes centricular#110
@MathieuDuponchelle
Copy link
Collaborator

Thanks :)

@MathieuDuponchelle MathieuDuponchelle merged commit f4692cb into centricular:main Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal runtime error: failed to initiate panic, error 5. Aborted (core dumped) when closing the web

2 participants