This repository was archived by the owner on Oct 24, 2022. It is now read-only.
Update dependencies using the new Signall::builder API #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Aug 16, 2022
sdroege
reviewed
Aug 16, 2022
|
Also best to wait for gtk-rs/gtk-rs-core#734 (comment) |
c656952 to
f22a381
Compare
|
@sdroege your comment is addressed here right? |
|
No |
|
ah my bad |
This hasn't been done yet afaiu. Other comments should be addressed |
OK, please just merge when done then :) |
|
gtk-rs/gtk-rs-core#748 is pending, then this can go in |
|
That one is merged now |
f22a381 to
3ea4d8c
Compare
|
Updated, should be good to go. |
|
thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.