-
Notifications
You must be signed in to change notification settings - Fork 23
Added support for memory NVMM #75
Conversation
Added nv4l2vp8enc and nv4l2h264enc for memory nvmm
Looks good to me otherwise, thanks for taking the time to propose this 👍 |
Ah, also please fix the history to propose a single commit :) |
ping @massis08 :) |
1 similar comment
ping @massis08 :) |
Sorry @MathieuDuponchelle, I have been out of the office these past weeks. As soon as I can I will work on the PR! |
Great, thanks :) |
…g-encoders 20220713 optimize webrsink sharing encoders
hrm, @massis08 this is a bit of a mess :) |
@MathieuDuponchelle I have seen that there as been many modifications to the code. Maybe it is best if I just cancel this PR, and create a new branch, make the necessary changes to support memory NVMM and then create a new PR. What do you think? |
@massis08 yes, Merge Requests should be as atomic as possible. Also you should try to answer questions from reviewers, it otherwise makes reviews pretty pointless ;) #75 (review) |
Added support for memory NVMM