Skip to content
This repository was archived by the owner on Oct 24, 2022. It is now read-only.

Conversation

massis08
Copy link

Added support for memory NVMM

@MathieuDuponchelle
Copy link
Collaborator

Looks good to me otherwise, thanks for taking the time to propose this 👍

@MathieuDuponchelle
Copy link
Collaborator

Ah, also please fix the history to propose a single commit :)

@MathieuDuponchelle
Copy link
Collaborator

ping @massis08 :)

1 similar comment
@MathieuDuponchelle
Copy link
Collaborator

ping @massis08 :)

@massis08
Copy link
Author

massis08 commented Aug 9, 2022

Sorry @MathieuDuponchelle, I have been out of the office these past weeks. As soon as I can I will work on the PR!

@MathieuDuponchelle
Copy link
Collaborator

Great, thanks :)

…g-encoders

20220713 optimize webrsink sharing encoders
@MathieuDuponchelle
Copy link
Collaborator

hrm, @massis08 this is a bit of a mess :)

@massis08
Copy link
Author

@MathieuDuponchelle I have seen that there as been many modifications to the code. Maybe it is best if I just cancel this PR, and create a new branch, make the necessary changes to support memory NVMM and then create a new PR. What do you think?

@MathieuDuponchelle
Copy link
Collaborator

@massis08 yes, Merge Requests should be as atomic as possible. Also you should try to answer questions from reviewers, it otherwise makes reviews pretty pointless ;) #75 (review)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants