let pymongo serialize task_meta natively if native_serialize backend option set #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now all the task_meta are "double encoded" in a Binary format (mongo BinData), only pickle and msgpack should need this while json and yaml can be saved as a string (actually a "strict" json format could be saved natively in mongo too, but didn't test this), with this patch:
it was not possible to create a kombu mongo serializer since it would have been useless or just needed to check if the object can be serializable (and then it would need to be serialized again) because pymongo don't recognize that we are sending BSON data to it and it would get double encoded (should it be needed a patch could also be submitted upstream to pymongo)