LocationDB #787
Merged
LocationDB #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for reviewer: this is a 4 commits PR, to easier the review task. They can be squashed after, if this level of detail is too much |
ad7aabf to
d314460
Compare
w4kfu
pushed a commit
to w4kfu/miasm
that referenced
this pull request
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows and should complete the
ExprLocpatch (#751)AsmSymbolPoolis replaced byLocationDB, which is no more specifically linked to ASM. This is a kind of database, in which entries are location, each uniquely identified by aLocKey.A location can be associated to zero, one or several names, and zero or one offset. As a result, there is no more need to always have a name for each location. In others words, the right way to specify in a unique manner a place in the code / data / generated (for instance, in IR blocks) is a LocKey. Offsets and names are just additionnal info, useful for example in asm or visualisation tasks.
Old APIs have been deprecated, and old code should be still working.