Typos on #71 & #88 #138
Closed
Typos on #71 & #88 #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvonimirfras
requested changes
Oct 1, 2018
| - reference the related issue | ||
| - "closes #123" or "fixes #123" will close issue #123 once the PR is merged | ||
| - "issue #123" just refences the issue. Only use this if you definitly need the issue to remain open. | ||
| - "issue #123" just references the issue. Only use this if you definitively need the issue to remain open. |
There was a problem hiding this comment.
definitly is actually meant to be an emphasis definitely
Suggested change
| - "issue #123" just references the issue. Only use this if you definitively need the issue to remain open. | |
| - "issue #123" just references the issue. Only use this if you definitely need the issue to remain open. |
zvonimirfras
reviewed
Oct 1, 2018
| - relevant code snippets | ||
| - links to application source code or running demo ([Codesandbox is awesome for this!](https://codesandbox.io/s/angular)) (including connection/authentication information) | ||
| - add relevant labels (bug, accsibility, design, discussion, feature, etc) | ||
| - add relevant labels (bug, accesibility, design, discussion, feature, etc) |
There was a problem hiding this comment.
Also, accessibility
Suggested change
| - add relevant labels (bug, accesibility, design, discussion, feature, etc) | |
| - add relevant labels (bug, accessibility, design, discussion, feature, etc) |
|
Hey! Just checking if you've had a chance to look at this recently? If not no worries, but we may close this out. |
|
🎉 This issue has been resolved in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IBM/carbon-components-angular#
Fixed typos on both strings 71 & 88
Changelog
New
Changed
Removed