Skip to content

Conversation

@mahdi-behnam
Copy link
Contributor

@mahdi-behnam mahdi-behnam commented Sep 19, 2025

  • OS: Windows 11 (used WSL)
  • CPU: Ryzen 7 5800H
  • RAM: 16GB
  • Storage: SSD
  • Python: 3.12.2
  • Java: OpenJDK 21.0.7

Results:

  • I had to change bin/run.sh to use -Xmx8G because I ran out of memory. Even so, everything worked.

Suggestions:

  • I think it is better to use a regex-anchored grep to ensure the ID is in the first column, e.g., grep -P '^999391\t' runs/run.msmarco-passage.dev.bm25.tsv | head since plain grep 999391 ... | head can also match IDs appearing in later columns.

@lintool
Copy link
Member

lintool commented Sep 20, 2025

hi @mahdi-behnam please fix conflicts.

@mahdi-behnam
Copy link
Contributor Author

Hi @lintool, I have resolved the conflicts.

@lintool lintool self-requested a review September 20, 2025 16:48
@lintool lintool merged commit aaff1ef into castorini:master Sep 20, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants