fix: Make "Show note on public booking page" consistent across all views of OOO #25827
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update weekly view to display OOO when showNotePublicly is true - Update column view to include days with public notes in schedule - Add notes and showNotePublicly props to weekly view calendar - Disable show note publicly checkbox when notes field is empty
CarinaWolli
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Inconsistent Behaviour:
Screen.Recording.2025-12-12.at.5.51.51.PM.mov
no validation:
Screen.Recording.2025-12-12.at.5.52.47.PM.mov
After:
Screen.Recording.2025-12-12.at.6.17.32.PM.mov
What does this PR do?
Fixes inconsistent behavior of the OOO "Show note on public booking page" feature across different booking views (month, column, weekly).
Problem
Solution
Applied consistent logic across all views:
OOO is displayable = toUser exists OR showNotePublicly is trueChanges
Weekly View (
packages/features/calendars/weeklyview/components/event/Empty.tsx)showNotePubliclyis true (even without redirect)notesandshowNotePubliclyprops toOutOfOfficeInSlotscomponentColumn View (
packages/features/schedules/lib/use-schedule/useNonEmptyScheduleDays.ts)Types (
packages/features/calendars/weeklyview/types/state.ts)notesandshowNotePubliclytoTimeRangeExtendedtypeValidation (
packages/features/settings/outOfOffice/CreateOrEditOutOfOfficeModal.tsx)