-
Notifications
You must be signed in to change notification settings - Fork 11.3k
fix: a11y add aria-label to progressToast close button #25618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: a11y add aria-label to progressToast close button #25618
Conversation
|
@Huor97 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
dhairyashiil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼 Thank you for the contribution. I can see this is your first PR in Cal, so welcome! Feel free to work on other open issues, and ping me if you need any help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
What does this PR do?
Adds an
aria-labelattribute to the close button in the ProgressToast component to improve accessibility for screen reader users. The button previously had only a visual icon ("x") without a text alternative, making it difficult for assistive technology users to understand its purpose.Visual Demo (For contributors especially)
Code Change:
Before:
After:
The close button now announces "close" to screen readers, making it clear what the button does.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Environment variables: None
Expected behavior: Close button now accessible to screen readers
Checklist