Skip to content

Conversation

@volnei
Copy link
Contributor

@volnei volnei commented Dec 3, 2025

What does this PR do?


Summary by cubic

Fixed the OIDC discovery URL in the Companion OAuth service so the app passes the base Cal.com URL to AuthSession, restoring proper discovery and login flow across platforms.

  • Bug Fixes
    • Use config.calcomBaseUrl directly with AuthSession.fetchDiscoveryAsync instead of appending /.well-known/openid_configuration, preventing discovery failures.

Written for commit c336370. Summary will update automatically on new commits.

@volnei volnei marked this pull request as ready for review December 3, 2025 12:51
@graphite-app graphite-app bot requested a review from a team December 3, 2025 12:51
@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cal-companion Ready Ready Preview Comment Dec 3, 2025 7:10pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Dec 3, 2025 7:10pm
cal-eu Ignored Ignored Dec 3, 2025 7:10pm

const discovery = await AuthSession.fetchDiscoveryAsync(
`${this.config.calcomBaseUrl}/.well-known/openid_configuration`
);
const discovery = await AuthSession.fetchDiscoveryAsync(this.config.calcomBaseUrl);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volnei Why do we need to remove the extra URL segments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's being included twice

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@volnei volnei merged commit 2fc1078 into main Dec 3, 2025
39 of 40 checks passed
@volnei volnei deleted the chore-companion-oidc-fix branch December 3, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants