Skip to content

fix: allow env var to override non-zero struct values (#364) #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow env var to override non-zero struct values (#364) #365

wants to merge 1 commit into from

Conversation

jyr94
Copy link

@jyr94 jyr94 commented Jul 15, 2025

Fixes #364

What this does

  • Ensures that environment variables override struct values,
    even when SetDefaultsForZeroValuesOnly is true.
  • Adjusts get(...) to return a flag indicating the value source.
  • Modifies setField to prioritize env vars.
  • Adds a test that reproduces the bug.

Why

The current logic prevents environment values from being applied
when the struct field is non-zero, which is not the intended behavior.

@jyr94 jyr94 mentioned this pull request Jul 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Values are not loaded from environment with SetDefaultsForZeroValuesOnly
1 participant
@jyr94