devenv: propagate the exit code when executing a shell command #1837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying devenv with
|
| Latest commit: |
9086d89
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2166592b.devenv.pages.dev |
| Branch Preview URL: | https://fix-1836.devenv.pages.dev |
|
Thanks for the swift reaction! Briefly tried it out and can confirm that this now correctly passes on the error code. |
c77eb7b to
21453c7
Compare
This ensures we correctly pass arguments to the command being exec-ed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1836.