Add readiness check for rabbitmq #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenonameguy
reviewed
Jun 6, 2023
| process-compose = { | ||
| readiness_probe = { | ||
| exec.command = "${cfg.package}/bin/rabbitmq-diagnostics -q ping"; | ||
| initial_delay_seconds = 10; |
Contributor
There was a problem hiding this comment.
This seems a tad bit too high for me.
It should be fine to have the check fail a few times in case the process starts up faster than 10 seconds.
Contributor
Author
There was a problem hiding this comment.
It was about 8 seconds on my M1 Pro, and with a 10 second period, it would end up being something like 20 seconds before it would be considered ready otherwise. I can definitely lower it, though, maybe even switch to a 5 second period instead. It's not a very taxing command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a readiness check very similar to what is done in the Docker world to check for rabbitmq readiness.
I have some async workers that can boot faster than rabbitmq, so it would be nice to have a healthcheck that gates my code until the process actually responds.