Lagrangian sign convention in ASL: call the scaling function once instead of flipping the signs #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the signs at every Hessian evaluation
Owner
Author
|
@amontoison have you ever seen a CI error like that before? |
Collaborator
|
@cvanaret GitHub is in maintenance, some downloads are failing because of that. |
Owner
Author
|
Ah I see! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uno uses the convention$\nabla^2 L(x, y) = \nabla^2 f(x) - \sum_j y_j \nabla^2 c_j(x)$ , while ASL uses a + sign.$y$ at every Hessian evaluation.
We now call
lagscale_ASLonce instead of flipping the signs of