Skip to content
This repository was archived by the owner on May 26, 2022. It is now read-only.

Conversation

@sfichera
Copy link
Contributor

Enhancement related to issue #172...

@boxcla
Copy link

boxcla commented Feb 11, 2016

Hi @sfichera, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@sfichera
Copy link
Contributor Author

CLA signed

@boxcla
Copy link

boxcla commented Feb 11, 2016

Verified that @sfichera has just signed the CLA. Thanks, and we look forward to your contribution.

@adrilo
Copy link
Collaborator

adrilo commented Feb 12, 2016

It looks great! Do you mind adding a test for it?
You can add a CSV file with custom line endings in the tests/resources/csv folder and use this file in your test. It should be straightforward :)

@adrilo
Copy link
Collaborator

adrilo commented Feb 14, 2016

👍 Thanks!

adrilo added a commit that referenced this pull request Feb 14, 2016
Support for variable EOL for CSV
@adrilo adrilo merged commit 771afcb into box:master Feb 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants