Add basic support for components and livewire attribute validation #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
approved these changes
Apr 24, 2024
Collaborator
AJenbo
left a comment
There was a problem hiding this comment.
Really nice work, this is a big step for the tool 👍
Any chance you could add a test for some of this?
Contributor
Author
|
Sure can, tests now added. |
AJenbo
approved these changes
Apr 25, 2024
Contributor
Author
|
Fixed the CI issues. |
Contributor
|
Thank you 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for checking the data passed into the components so phpstan can analyze the attributes.
This fixes previously undetected issues like:
It does NOT verify any of the attributes match the requirement of the component
Regexes and surrounding code for parsing the tags has been taken from the Blade & Livewire projects.