Skip to content

Conversation

johanR04
Copy link
Contributor

@johanR04 johanR04 commented Jul 10, 2025

Fix #1381

@buhtz buhtz added this to the 1.6.0 (upcoming next) milestone Jul 10, 2025
@buhtz buhtz added the PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. label Jul 10, 2025
Copy link
Member

@buhtz buhtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
On behalf of the team, thank you for your contribution and taking the time to improve Back In Time. We appreciate it.

Your PR looks fine. I just made some minor suggestions.
Press "Commit suggestion" if you agree with them.

Additionally I suggest to add a TOC entry for your entry.

Best,
Christian

@buhtz buhtz added PR: Modifications requested Maintenance team requested modifications and waiting for their implementation and removed PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. labels Jul 10, 2025
johanR04 and others added 4 commits July 11, 2025 12:57
Co-authored-by: Christian Buhtz <[email protected]>
Co-authored-by: Christian Buhtz <[email protected]>
Co-authored-by: Christian Buhtz <[email protected]>
Co-authored-by: Christian Buhtz <[email protected]>
@buhtz
Copy link
Member

buhtz commented Jul 11, 2025

btw: Please add the file name gcm-diagnose.log to the .gitignore file in the root of the repo.

@johanR04
Copy link
Contributor Author

Thank you, I have now corrected according to your recommendations including the TOC entry. I also removed the unnecessary gcm-diagnose.log file. It is a file that was accidentally created when I ran a diagnose command of my git credential manager that was not working correctly.

Copy link
Member

@buhtz buhtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Johan,
On behalf of the team, thank you for your contribution and taking
the time to improve Back In Time. We appreciate it.

Your PR looks fine. It will get merged after a cool off period.
To find out how we usually tread PRs please read
"What happens after you opened a PullRequest (PR)?".

Best,
Christian

@buhtz buhtz added PR: Merge after creative-break Merge after creative-break (min. 1 week) and removed PR: Modifications requested Maintenance team requested modifications and waiting for their implementation labels Jul 11, 2025
@buhtz buhtz changed the title FaQ entry about how rsync handles open files doc(faq): Add entry about how rsync handles open files Jul 12, 2025
@buhtz buhtz merged commit 59ac34d into bit-team:dev Jul 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Merge after creative-break Merge after creative-break (min. 1 week)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How does BiT/rsync handle open files during taking a snapshot (backup)?

3 participants