Skip to content

fix: Set toogle button value before connecting it to its slot #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix: Set toogle button value before connecting it to its slot #1536

merged 2 commits into from
Sep 18, 2023

Conversation

buhtz
Copy link
Member

@buhtz buhtz commented Sep 16, 2023

This might fix #1535 .

Problem was that the value/state of the button "Show hidden files" was set after it was connected to its slot. This happened before the main window construction was finished. But it triggered some other events in the main window that couldn't be processed correct because that window itself is not finished with its construction.

Solution: Set the value of that button first and then connect it to its slot.

@buhtz
Copy link
Member Author

buhtz commented Sep 16, 2023

Just one line modified. Mhm...
The 1.4.0 release is only some hours old. I vote to delete the "v1.4.0" tag and re-do the 1.4.0 release instead of creating a 1.4.1.

@graysky2 graysky2 mentioned this pull request Sep 16, 2023
Closed
@aryoda
Copy link
Contributor

aryoda commented Sep 16, 2023

Problem was that the value/state of the button "Show hidden files" was set after it was connected to its slot.

The same class of problem may still exist for other edge cases unless *all actions are connected at the end of the constructor (__init__) only (or at least when we are sure the GUI state was completely initialized):

backintime/qt/app.py

Lines 129 to 131 in ddd142b

self._create_actions()
self._create_menubar()
self._create_main_toolbar()

We should do some more checks or code reviews here.

The 1.4.0 release is only some hours old. I vote to delete the "v1.4.0" tag and re-do the 1.4.0 release instead of creating a 1.4.1.

I really prefer to not manipulate a published Git history so I would go for 1.4.1.
The efforts are the same.

I can do this since it I am a release prepration Pro now 😉

@aryoda
Copy link
Contributor

aryoda commented Sep 16, 2023

@buhtz THX for investigating and fixing this! I could reproduce the problem too now. I will prepare a new minor release Sunday EOD (unless other urgent fixes pop up).

@aryoda
Copy link
Contributor

aryoda commented Sep 17, 2023

Ah, the CHANGElog entry is still missing ;-)

@aryoda
Copy link
Contributor

aryoda commented Sep 17, 2023

@buhtz FYI: I think we should keep this PR now as it is (no more commits) since it has an impact on the AUR package's checksum (the patch includes new commits):

https://aur.archlinux.org/pkgbase/backintime#comment-934159

@buhtz
Copy link
Member Author

buhtz commented Sep 18, 2023

OK. But just for my learning. I don't understand why it has an effect on the AUR because the it should refer to the latest release. So much to learn ... 🤣

@buhtz buhtz merged commit 37018e0 into bit-team:dev Sep 18, 2023
@buhtz buhtz deleted the fix/archsid branch September 18, 2023 05:38
@aryoda
Copy link
Contributor

aryoda commented Sep 18, 2023

I don't understand why it has an effect on the AUR

The patch in the AUR package references the github PR so the diff changes when we add commits:

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=backintime#n14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aryoda aryoda aryoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Breakage with 1.4.0 release (MainWindow has no attribute 'sid'; translator for language code "C")

2 participants

@buhtz @aryoda