-
Notifications
You must be signed in to change notification settings - Fork 259
Fix bug #1506: Treat rsync exit code 24 as INFO instead of ERROR #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So which string does a translator see on Weblate for this code in line 1252:
or
I was hoping the translator does see 1. If the translator sees 2. I am just curious how gettext/Weblate is able to extract all strings from the source code incl. applying all possible formats first (without executing the code with all possible values)! |
Part 2: Fix translation issues
Yes, this topic can make headaches. 😄
The translator on weblate will see nothing because the gettext utilities (e.g. If you want number 1 then you have to give exact that string to
But you will fill in the variable
The
The gettext tools (to my knowledge) all working on text-file-parsing. They do not execute code. Your example is ignored because it is not just a string. I see no need for "applying all possible formats first". The opposite should be the case. Strings should be translated before applying |
@buhtz THX a lot, static code analysis (searching for plain strings) is the simple magic in providing strings to Weblate So if I understand you right I should change line 1252 from
to
so that translators can rearrange the position of the |
Correct. |
Part 3: Fix translation issues
OK, all translations should now be enabled correctly |
Done :-)
@buhtz I hope the
gettext
translation does still work with my heavy string concatenation (required to avoid duplicated sub strings/prefixes in the messages)