Skip to content

Conversation

aryoda
Copy link
Contributor

@aryoda aryoda commented Mar 3, 2023

Fixes #1410

Urgently required for the upcoming Debian BiT release.

Successfully ested via my local openSSH server and a password on my private key file...

For testing you can change the default keyring backend via a config file
(see instructions: https://github.com/bit-team/backintime#non-working-password-safe-and-bit-forgets-passwords-keyring-backend-issues)

Please review.

Further tests welcome.

@aryoda
Copy link
Contributor Author

aryoda commented Mar 3, 2023

@buhtz One of the Travis CI builds did not succeed (looks like a connection timeout). Do you have the rights to trigger the build again to be sure no unit test is failing in our build matrix? THX!

$ git clone --depth=50 https://github.com/bit-team/backintime.git bit-team/backintime
No output has been received in the last 10m0s, this potentially indicates a stalled build
or something wrong with the build itself.
...
The build has been terminated

@buhtz
Copy link
Member

buhtz commented Mar 3, 2023

You had a long night. 👍

About TravisCI: The problem is known but not understood yet. Happens only on "ppc64le" machine. I retriggered and it worked now. The Travis support told me to logout and login again. That worked also. If this happens more often I will recontact the support. But maybe we should switch from Ubuntu20 to Ubuntu22 after the Debian release.
You can create your own TravisCI account if you want. I assume the GitHub-Team-setup is reflected in Travis and you should be able to trigger builds then.

About your PR: Looks OK for me but I'm not a keyring user or pro. My review isn't much of a value. I would only say the code is not PEP8 conform (e.g. length of lines). But we have bigger "problems". 😄

@aryoda
Copy link
Contributor Author

aryoda commented Mar 5, 2023

I would only say the code is not PEP8 conform (e.g. length of lines)

Yes, I have to admit I quite often ignore the PEP8 max length of line rule for better readability (my quite personal and biased opinion ;-)

I am merging now, for Debian a PR containing this code as patch is on its way:

https://salsa.debian.org/jmw/pkg-backintime/-/merge_requests/9

@aryoda aryoda merged commit 40ef31c into bit-team:dev Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants