-
-
Notifications
You must be signed in to change notification settings - Fork 14
refactor: use bun for development #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7d68638
to
2043bc4
Compare
Oh forgot to check the test file haha! Looking into it. EDIT: I believe it's only because I did not run |
4190170
to
68b8eb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bun 1.0 doesn't work on windows, which is a show-stopper. Please update to 1.1
68b8eb8
to
d504211
Compare
tsc —noEmit is failing on both node and bun, will check later |
0241312
to
7dc1d0f
Compare
That should be it :) |
This pull request is welcome because using Bun as a bundler and a package manager here allows us to remove a bunch of dependencies. Still, I'm not sure this solves #44 because the original intent was to use Bun to run the script. |
Co-authored-by: Nicolas Hedger <[email protected]>
Co-authored-by: Nicolas Hedger <[email protected]>
Co-authored-by: Nicolas Hedger <[email protected]>
Yeah agree, will update the description. We can add a Dockerfile to run the action with Bun, but I believe it would be slower because of fetching the Docker image instead of using the existing Node runner provided by GitHub. No? |
Not a fan of the Docker way either. Thanks for your contribution ! |
No description provided.