Skip to content

fix(semantic): track scope for TS construct signature type parameters #8459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyc3 merged 3 commits into from
Dec 15, 2025
+49 −14
Merged

fix(semantic): track scope for TS construct signature type parameters #8459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
790a664
fix(semantic): track scope for TS construct signature type parameters
ruidosujeira Dec 15, 2025
657d8dd
add changeset
ruidosujeira Dec 15, 2025
e6b1dc5
refactor changeset
ruidosujeira Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-construct-signature-unused-type-param.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@biomejs/biome": patch
---

Fix [#8435](https://github.com/biomejs/biome/issues/8435): resolved false positive in `noUnusedVariables` for generic type parameters in construct signature type members (`new <T>(): T`).
27 changes: 21 additions & 6 deletions crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/validInterface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,30 @@
/* should not generate diagnostics */

interface A {
f(a: number);
set a(a: number);
[key: string]: string;
f(a: number);
set a(a: number);
[key: string]: string;
}

// Construct signature type members with generic parameters
export interface Constructor {
new <T>(): T;
new <T>(value: T): T;
}

export interface ConstructorWithMultipleOverloads {
new <T>(): T;
<T>(): T;
}

class B implements A {
f(a: number) {console.log(a)}
set a(a: number) {console.log(a)}
[key: string]: string;
f(a: number) {
console.log(a);
}
set a(a: number) {
console.log(a);
}
[key: string]: string;
}

console.log(new B());
29 changes: 21 additions & 8 deletions crates/biome_js_analyze/tests/specs/correctness/noUnusedVariables/validInterface.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,32 @@ expression: validInterface.ts
/* should not generate diagnostics */

interface A {
f(a: number);
set a(a: number);
[key: string]: string;
f(a: number);
set a(a: number);
[key: string]: string;
}

// Construct signature type members with generic parameters
export interface Constructor {
new <T>(): T;
new <T>(value: T): T;
}

export interface ConstructorWithMultipleOverloads {
new <T>(): T;
<T>(): T;
}

class B implements A {
f(a: number) {console.log(a)}
set a(a: number) {console.log(a)}
[key: string]: string;
f(a: number) {
console.log(a);
}
set a(a: number) {
console.log(a);
}
[key: string]: string;
}

console.log(new B());

```


2 changes: 2 additions & 0 deletions crates/biome_js_semantic/src/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ impl SemanticEventExtractor {
| TS_DECLARE_FUNCTION_DECLARATION
| TS_DECLARE_FUNCTION_EXPORT_DEFAULT_DECLARATION
| TS_CALL_SIGNATURE_TYPE_MEMBER
| TS_CONSTRUCT_SIGNATURE_TYPE_MEMBER
| TS_METHOD_SIGNATURE_CLASS_MEMBER
| TS_METHOD_SIGNATURE_TYPE_MEMBER
| TS_INDEX_SIGNATURE_CLASS_MEMBER
Expand Down Expand Up @@ -866,6 +867,7 @@ impl SemanticEventExtractor {
| TS_DECLARE_FUNCTION_DECLARATION
| TS_DECLARE_FUNCTION_EXPORT_DEFAULT_DECLARATION
| TS_CALL_SIGNATURE_TYPE_MEMBER
| TS_CONSTRUCT_SIGNATURE_TYPE_MEMBER
| TS_METHOD_SIGNATURE_CLASS_MEMBER
| TS_METHOD_SIGNATURE_TYPE_MEMBER
| TS_INDEX_SIGNATURE_CLASS_MEMBER
Expand Down
Loading