fix(noUnknownMediaFeatureName): fix typo in prefers-reduced-transparency #8444

tt-a1i · 2025-12-14T03:14:25Z

Summary

Fix typo in MEDIA_FEATURE_NAMES array: prefers-reduded-transparency → prefers-reduced-transparency.

This fixes the false positive reported in #8029 where @media (prefers-reduced-transparency: reduce) was incorrectly flagged as an unknown media feature.

Test plan

Added test case for prefers-reduced-transparency in valid.css
Verified no diagnostic is produced for the valid media query

Closes #8029

changeset-bot · 2025-12-14T03:14:29Z

🦋 Changeset detected

Latest commit: 13f24c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-12-14T03:17:19Z

Walkthrough

This pull request corrects a typographical error in the CSS media feature keywords list where "prefers-reduded-transparency" was misspelled. The fix updates the keyword to the correct spelling "prefers-reduced-transparency" in accordance with the CSS Media Queries Level 5 specification. A corresponding test case is added to validate the media feature is now properly recognised, and a changeset entry documents the patch release for the noUnknownMediaFeatureName rule.

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: fixing a typo in the prefers-reduced-transparency media feature name.
Description check	✅ Passed	The description directly addresses the changeset, explaining the typo fix and its impact on the noUnknownMediaFeatureName rule.
Linked Issues check	✅ Passed	The pull request successfully resolves the linked issue #8029 by adding the missing media feature to the keywords list and providing a test case.
Out of Scope Changes check	✅ Passed	All changes are tightly scoped to fixing the typo and adding validation; no unrelated modifications detected.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

.changeset/fix-prefers-reduced-transparency-typo.md (1)

5-5: Consider a more user-focused description (optional).

The current description is clear, but could emphasise the user impact more directly. Consider:

"Fixed noUnknownMediaFeatureName to correctly recognise prefers-reduced-transparency. Previously reported a false positive due to a typo in the keywords list (prefers-reduded-transparency)."

As per coding guidelines, this puts the user benefit (no false positive) front and centre.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a392c06 and 13f24c2.

⛔ Files ignored due to path filters (1)

crates/biome_css_analyze/tests/specs/correctness/noUnknownMediaFeatureName/valid.css.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (3)

.changeset/fix-prefers-reduced-transparency-typo.md (1 hunks)
crates/biome_css_analyze/src/keywords.rs (1 hunks)
crates/biome_css_analyze/tests/specs/correctness/noUnknownMediaFeatureName/valid.css (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

crates/**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Update inline rustdoc documentation for rules, assists, and their options when adding new features or changing existing features in Rust crates

Files:

crates/biome_css_analyze/src/keywords.rs

.changeset/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Write changesets that are concise (1-3 sentences), user-focused, use past tense for actions taken and present tense for Biome behavior, include code examples for rules, and end sentences with periods

Files:

.changeset/fix-prefers-reduced-transparency-typo.md

🧠 Learnings (10)

📚 Learning: 2025-11-24T18:05:42.356Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:42.356Z
Learning: Applies to crates/biome_js_type_info/**/*.rs : Distinguish between `TypeData::Unknown` and `TypeData::UnknownKeyword` to measure inference effectiveness versus explicit user-provided unknown types

Applied to files:

crates/biome_css_analyze/src/keywords.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noUnknown` prefix for rules that report mistyped entities in CSS (e.g., `noUnknownUnit`)

Applied to files:

crates/biome_css_analyze/src/keywords.rs
crates/biome_css_analyze/tests/specs/correctness/noUnknownMediaFeatureName/valid.css

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use language tags in documentation code blocks (js, ts, tsx, json, css) and order properties consistently as: language, then `expect_diagnostic`, then options modifiers, then `ignore`, then `file=path`

Applied to files:

crates/biome_css_analyze/src/keywords.rs

📚 Learning: 2025-11-24T18:05:42.356Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:42.356Z
Learning: Applies to crates/biome_js_type_info/**/*.rs : Use `TypeReference` instead of `Arc` for types that reference other types to avoid stale cache issues when modules are replaced

Applied to files:

crates/biome_css_analyze/src/keywords.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noUndeclared` prefix for rules that report undefined entities (e.g., `noUndeclaredVariables`)

Applied to files:

crates/biome_css_analyze/src/keywords.rs

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/language_kind.rs : Add a new language prefix to the `LANGUAGE_PREFIXES` constant in `language_kind.rs` file

Applied to files:

crates/biome_css_analyze/src/keywords.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Check if a variable is global before banning it to avoid false positives when the variable is redeclared in local scope; use the semantic model to verify global scope

Applied to files:

crates/biome_css_analyze/src/keywords.rs

📚 Learning: 2025-12-12T10:11:05.549Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-12T10:11:05.549Z
Learning: Applies to crates/**/*.rs : Update inline rustdoc documentation for rules, assists, and their options when adding new features or changing existing features in Rust crates

Applied to files:

crates/biome_css_analyze/src/keywords.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/*analyze/src/lint/**/*.rs : Use the `noRedundant` prefix for rules that report redundant code (e.g., `noRedundantUseStrict`)

Applied to files:

crates/biome_css_analyze/src/keywords.rs

📚 Learning: 2025-11-27T23:04:02.022Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-11-27T23:04:02.022Z
Learning: Applies to crates/biome_analyze/**/biome_rule_options/src/**/*.rs : Use `Box<[T]>` instead of `Vec<T>` for rule options array fields to save memory (boxed slices and boxed str use 2 words instead of three words)

Applied to files:

crates/biome_css_analyze/src/keywords.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Documentation
GitHub Check: Check Dependencies
GitHub Check: autofix
GitHub Check: Test Node.js API
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Bench (biome_css_parser)
GitHub Check: Bench (biome_css_formatter)

🔇 Additional comments (2)

crates/biome_css_analyze/src/keywords.rs (1)

5153-5153: LGTM! Typo corrected.

The spelling now matches the CSS Media Queries Level 5 specification.

crates/biome_css_analyze/tests/specs/correctness/noUnknownMediaFeatureName/valid.css (1)

22-24: Good test coverage.

The test case confirms the corrected media feature name is now properly recognised.

codspeed-hq · 2025-12-14T03:22:43Z

CodSpeed Performance Report

Merging #8444 will not alter performance

_{Comparing tt-a1i:fix/prefers-reduced-transparency-typo (13f24c2) with main (a78774b)¹}

Summary

✅ 29 untouched
⏩ 126 skipped²

No successful run was found on main (a392c06) during the generation of this report, so a78774b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
126 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

…ncy (biomejs#8444)

fix(noUnknownMediaFeatureName): fix typo in prefers-reduced-transparency

13f24c2

github-actions bot added A-Linter Area: linter L-CSS Language: CSS labels Dec 14, 2025

coderabbitai bot reviewed Dec 14, 2025

View reviewed changes

dyc3 approved these changes Dec 14, 2025

View reviewed changes

dyc3 merged commit 8caa7a0 into biomejs:main Dec 14, 2025
18 checks passed

This was referenced Dec 14, 2025

ci: release #8286

Merged

ci: release #8467

Merged

ci: release #8469

Merged

l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025

fix(noUnknownMediaFeatureName): fix typo in prefers-reduced-transpare…

f6f32bd

…ncy (biomejs#8444)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(noUnknownMediaFeatureName): fix typo in prefers-reduced-transparency #8444

fix(noUnknownMediaFeatureName): fix typo in prefers-reduced-transparency #8444

tt-a1i commented Dec 14, 2025

Uh oh!

changeset-bot bot commented Dec 14, 2025

Uh oh!

coderabbitai bot commented Dec 14, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

codspeed-hq bot commented Dec 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(noUnknownMediaFeatureName): fix typo in prefers-reduced-transparency #8444

fix(noUnknownMediaFeatureName): fix typo in prefers-reduced-transparency #8444

Conversation

tt-a1i commented Dec 14, 2025

Summary

Test plan

Uh oh!

changeset-bot bot commented Dec 14, 2025

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Dec 14, 2025

Walkthrough

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Dec 14, 2025

CodSpeed Performance Report

Merging #8444 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants