-
-
Notifications
You must be signed in to change notification settings - Fork 791
chore: add flags to regex literals #8279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThis PR enhances RegExp literal handling in the type information system across multiple modules. It introduces a new Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
🧰 Additional context used📓 Path-based instructions (3)**/*.rs📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
crates/biome_js_type_info/**/*.rs📄 CodeRabbit inference engine (crates/biome_js_type_info/CONTRIBUTING.md)
Files:
crates/biome_js_type_info/**/local_inference.rs📄 CodeRabbit inference engine (crates/biome_js_type_info/CONTRIBUTING.md)
Files:
🧠 Learnings (26)📚 Learning: 2025-11-24T18:05:27.784ZApplied to files:
📚 Learning: 2025-11-24T18:05:20.343ZApplied to files:
📚 Learning: 2025-11-24T18:05:27.784ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.337ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-11-24T18:05:27.784ZApplied to files:
📚 Learning: 2025-11-24T18:05:20.343ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-11-24T18:03:52.013ZApplied to files:
📚 Learning: 2025-11-24T18:05:42.338ZApplied to files:
📚 Learning: 2025-08-20T16:24:59.781ZApplied to files:
📚 Learning: 2025-11-24T18:06:03.536ZApplied to files:
📚 Learning: 2025-11-24T18:06:03.536ZApplied to files:
📚 Learning: 2025-11-24T18:06:03.536ZApplied to files:
📚 Learning: 2025-11-24T18:04:42.146ZApplied to files:
📚 Learning: 2025-11-24T18:04:42.146ZApplied to files:
📚 Learning: 2025-11-24T18:06:03.536ZApplied to files:
📚 Learning: 2025-11-24T18:04:42.146ZApplied to files:
📚 Learning: 2025-11-24T18:06:03.536ZApplied to files:
🧬 Code graph analysis (2)crates/biome_js_type_info/src/format_type_info.rs (2)
crates/biome_js_type_info/tests/local_inference.rs (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
🔇 Additional comments (9)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
CodSpeed Performance ReportMerging #8279 will not alter performanceComparing Summary
Footnotes
|
|
Hopefully that's it :) |
Summary
Follow-up to #8166, this adds flags to the regex literals.
@Netail Anything else you would need to finish up #8034?
Test Plan
Test added.
Docs
Inline comments.