fix: noSyncScripts type="module" #8149

Netail · 2025-11-18T13:12:40Z

Summary

script tags with type="module" are non-blocking; https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script#blocking

Closes #8144

Test Plan

Docs

changeset-bot · 2025-11-18T13:12:45Z

🦋 Changeset detected

Latest commit: c4c53c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dyc3 · 2025-11-18T13:25:56Z

.changeset/pretty-pumas-float.md

+"@biomejs/biome": patch
+---
+
+Improve noSyncScripts, ignore script tags with `type="module"`


Link the issue that this is fixing

codspeed-hq · 2025-11-18T13:29:40Z

CodSpeed Performance Report

Merging #8149 will not alter performance

_{Comparing Netail:fix/no-sync-scripts-type (c4c53c0) with main (2dd38cf)¹}

Summary

✅ 58 untouched
⏩ 95 skipped²

No successful run was found on main (1fbdff5) during the generation of this report, so 2dd38cf was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ematipico

Nice!!

.changeset/pretty-pumas-float.md

arendjr

The fix looks alright, but I think we may need to be a bit more careful with the implementation.

arendjr · 2025-11-18T13:44:25Z

crates/biome_html_analyze/src/lint/nursery/no_sync_scripts.rs

+                attribute.initializer().is_some_and(|initializer| {
+                    initializer.value().ok().is_some_and(|value| {
+                        value.as_html_string().is_some_and(|html_string| {
+                            html_string.inner_string_text().unwrap().text() == "module"


Is this unwrap() safe?

Added a check

arendjr · 2025-11-18T13:45:28Z

crates/biome_html_factory/src/make.rs

 }
+
+/// Create a new string literal token with no attached trivia
+pub fn html_string_literal(text: &str) -> HtmlSyntaxToken {


Does this get used anywhere in the PR?

It's used in the example of inner_string_text. The CI seemed to fail on that implementation missing even tho it's it's only in the docs

arendjr · 2025-11-18T13:46:19Z

crates/biome_html_syntax/src/string_ext.rs

+    ///     .with_leading_trivia(vec![(TriviaPieceKind::Whitespace, " ")]));
+    /// assert_eq!(string.inner_string_text().unwrap().text(), "button");
+    /// ```
+    pub fn inner_string_text(&self) -> SyntaxResult<TokenText> {


What is the purpose of this wrapper function?

To make it easier to access the inner string text; js, json, css also have such wrapper function

How much easier is it if we already have one?

The css, json, css wrapper functions are not available on the HtmlString

inner_string_text(html_string.value_token()?).ok()?.text() vs
html_string.inner_string_text?.text()

basically continued the pattern that was already in place, to make inner_string_text a function of a syntax String, but missing for HtmlString

Mhm thoughts? @ematipico @dyc3

arendjr · 2025-11-18T13:48:08Z

crates/biome_js_analyze/src/lint/nursery/no_sync_scripts.rs

+            attribute.initializer().is_some_and(|initializer| {
+                initializer.value().ok().is_some_and(|value| {
+                    value.as_jsx_string().is_some_and(|jsx_string| {
+                        jsx_string.inner_string_text().unwrap().text() == "module"


Also mind this unwrap() please.

Added a check

github-actions bot added A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages L-HTML Language: HTML and super languages labels Nov 18, 2025

Netail force-pushed the fix/no-sync-scripts-type branch from c6741e6 to ff17ff3 Compare November 18, 2025 13:19

dyc3 approved these changes Nov 18, 2025

View reviewed changes

fix: noSyncScripts type="module"

341bd21

Netail force-pushed the fix/no-sync-scripts-type branch from ff17ff3 to 341bd21 Compare November 18, 2025 13:27

fix: feedback

ccbe1e6

ematipico approved these changes Nov 18, 2025

View reviewed changes

siketyan approved these changes Nov 18, 2025

View reviewed changes

.changeset/pretty-pumas-float.md Outdated Show resolved Hide resolved

arendjr reviewed Nov 18, 2025

View reviewed changes

fix: feedback

c4c53c0

arendjr approved these changes Nov 19, 2025

View reviewed changes

Netail merged commit e0a02bf into biomejs:main Nov 19, 2025
17 checks passed

Netail deleted the fix/no-sync-scripts-type branch November 19, 2025 08:32

github-actions bot mentioned this pull request Nov 19, 2025

ci: release #8161

Merged

Uh oh!

fix: noSyncScripts type="module" #8149

fix: noSyncScripts type="module" #8149

Uh oh!

Conversation

Netail commented Nov 18, 2025

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging #8149 will not alter performance

Summary

Footnotes

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arendjr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Netail Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Netail Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Netail Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Netail Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

changeset-bot bot commented Nov 18, 2025 •

edited

Loading

codspeed-hq bot commented Nov 18, 2025 •

edited

Loading

arendjr left a comment •

edited

Loading

Netail Nov 18, 2025 •

edited

Loading

Netail Nov 18, 2025 •

edited

Loading

Netail Nov 18, 2025 •

edited

Loading

Netail Nov 18, 2025 •

edited

Loading