fix(biome_html_parser): fix incorrect option name in HTML parser error message #7867
+18
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e498d81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
26c7e9e to
41b04e5
Compare
…r message The error message for disabled text expressions incorrectly referred to the `html.parser.textExpression` option, which does not exist. Update it to reference the correct `html.parser.interpolation` option. Signed-off-by: Sora Morimoto <[email protected]>
41b04e5 to
6951833
Compare
dyc3
approved these changes
Oct 25, 2025
Contributor
dyc3
left a comment
There was a problem hiding this comment.
Good catch, thank you!
Just fix the wording in the changeset :)
Contributor
WalkthroughThis change corrects a misnamed HTML parser option reference in an error message. The Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Sora Morimoto <[email protected]>
ematipico
approved these changes
Oct 25, 2025
Merged
Jagget
pushed a commit
to Jagget/biome
that referenced
this pull request
Oct 27, 2025
…r message (biomejs#7867) Signed-off-by: Sora Morimoto <[email protected]>
Conaclos
pushed a commit
that referenced
this pull request
Nov 1, 2025
…r message (#7867) Signed-off-by: Sora Morimoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The HTML parser error message for disabled text expressions incorrectly referred to the non-existent
html.parser.textExpressionoption. This pull request fixes the error message to reference the correcthtml.parser.interpolationoption, which is the actual configuration option for enabling interpolation parsing in HTML files.Test Plan
Updated all related snapshot files. Existing tests will verify that the error message now displays the correct option name when users encounter text expressions with interpolation disabled.
Docs
No documentation changes required as this is a bug fix for an error message.
The corrected option name (
html.parser.interpolation) already exists in the configuration schema.