crates/biome_test_utils/src/lib.rs (2)

217-242: LGTM! Consider optional refactor to avoid double-reading.

The change correctly uses read_manifest to ensure initialize_paths is called. However, the file is read twice: once at line 218 and again inside read_manifest at line 219.

For a minor optimisation, you could call read_manifest directly and only read the file again for diagnostics if errors occur, avoiding double-reading in the success case.

Apply this diff for the optional refactor:

-    let package_json_file = input_file.with_extension("package.json");
-    if let Ok(json) = std::fs::read_to_string(&package_json_file) {
-        let deserialized = PackageJson::read_manifest(&fs, &package_json_file);
+    let package_json_file = input_file.with_extension("package.json");
+    let deserialized = PackageJson::read_manifest(&fs, &package_json_file);
+    if deserialized.has_errors() || deserialized.into_deserialized().is_some() {
         if deserialized.has_errors() {
+            let json = std::fs::read_to_string(&package_json_file).unwrap_or_default();
             diagnostics.extend(
                 deserialized
                     .into_diagnostics()
                     .into_iter()
                     .map(|diagnostic| {
                         diagnostic_to_string(
                             package_json_file.file_stem().unwrap(),
                             &json,
                             diagnostic,
                         )
                     }),
             );
         } else {
             project_layout.insert_node_manifest(
                 input_file
                     .parent()
                     .map(|dir_path| dir_path.to_path_buf())
                     .unwrap_or_default(),
                 deserialized.into_deserialized().unwrap_or_default(),
             );
         }
     }

---

244-265: LGTM! Same optional refactor applies here.

The tsconfig.json handling correctly uses read_manifest to ensure initialize_paths is called, which was the root cause of the failing CI tests. The same optional refactor to avoid double-reading (suggested for package.json) applies here as well.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-10-15T09:23:33.055Z
Learning: Applies to crates/biome_js_type_info/src/{type_info,local_inference,resolver,flattening}.rs : Avoid recursive type structures and cross-module Arcs; represent links between types using TypeReference and TypeData::Reference.