Skip to content

fix(useNamingConvention): don't panic on $ name #7825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
+56 −1
Merged

fix(useNamingConvention): don't panic on $ name #7825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-plants-tell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@biomejs/biome": patch
---

Fixed [#7798](https://github.com/biomejs/biome/issues/7798). [useNamingConvention](https://biomejs.dev/linter/rules/use-naming-convention/) no longer panics when it encounters a name that consists of a single dollar sign `$` that doesn't match a custom convention.
2 changes: 1 addition & 1 deletion crates/biome_js_analyze/src/lint/style/use_naming_convention.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ impl Rule for UseNamingConvention {
new_name.push_str(&name[..(name_range.start as _)]);
new_name.push_str(&new_name_part);
new_name.push_str(&name[(name_range.end as _)..]);
if name == new_name {
if name == new_name || new_name.is_empty() {
return None;
}
let mut mutation = ctx.root().begin();
Expand Down
1 change: 1 addition & 0 deletions crates/biome_js_analyze/tests/specs/style/useNamingConvention/invalidSIngleDollarName.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
const $ = 0;
22 changes: 22 additions & 0 deletions ...es/biome_js_analyze/tests/specs/style/useNamingConvention/invalidSIngleDollarName.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
source: crates/biome_js_analyze/tests/spec_tests.rs
expression: invalidSIngleDollarName.js
---
# Input
```js
const $ = 0;

```

# Diagnostics
```
invalidSIngleDollarName.js:1:7 lint/style/useNamingConvention ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i This variable name should be in camelCase or PascalCase or CONSTANT_CASE.

> 1 │ const $ = 0;
│ ^
2 │


```
27 changes: 27 additions & 0 deletions ...ome_js_analyze/tests/specs/style/useNamingConvention/invalidSIngleDollarName.options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"linter": {
"enabled": true,
"rules": {
"style": {
"useNamingConvention": {
"level": "warn",
"options": {
"strictCase": false,
"conventions": [
{
"selector": {
"kind": "variable"
},
"formats": [
"camelCase",
"CONSTANT_CASE",
"PascalCase"
]
}
]
}
}
}
}
}
}