crates/biome_fs/src/fs/memory.rs (1)

203-206: path_exists ignores directories; align behaviour with real FS

contains_key() returns false for folders that only exist via child entries (e.g. "dist/index.js"). This can cause false negatives versus an OS FS. Consider treating a path as existing if any key starts with it.

-    fn path_exists(&self, path: &Utf8Path) -> bool {
-        let files = self.files.0.read();
-        files.contains_key(path)
-    }
+    fn path_exists(&self, path: &Utf8Path) -> bool {
+        let files = self.files.0.read();
+        files.contains_key(path) || files.keys().any(|p| p.starts_with(path))
+    }

This also lets init detect a “dist” directory when only files under it are present.

crates/biome_configuration/src/vcs.rs (1)

68-76: Add rustdoc to the new constructor

Public helper lacks rustdoc. Add a brief comment to aid discoverability and keep API docs complete.

-    pub fn new_git_ignore() -> Self {
+    /// Convenience constructor enabling VCS integration with Git and using the ignore file.
+    /// Sets `enabled = true`, `clientKind = "git"`, and `useIgnoreFile = true`.
+    pub fn new_git_ignore() -> Self {
         Self {
             enabled: Some(true.into()),
             client_kind: Some(VcsClientKind::Git),
             use_ignore_file: Some(true.into()),
             root: None,
             default_branch: None,
         }
     }
```<!-- review_comment_end -->

</blockquote></details>
<details>
<summary>crates/biome_cli/tests/commands/format.rs (1)</summary><blockquote>

`3432-3432`: **HTML default now errors — confirm behaviour and rename test**

Expectation flips to error. Is HTML formatting now disabled by default? If intentional, consider renaming the test to reflect the new default, e.g. html_disabled_by_default, and ensure docs mention this.

 <!-- review_comment_end -->

</blockquote></details>
<details>
<summary>crates/biome_cli/tests/commands/init.rs (1)</summary><blockquote>

`43-61`: **Model dist as a directory for realism**

The test inserts "dist" as an empty file to trigger detection. Once MemoryFS.path_exists recognises directories (see separate comment), prefer inserting a child file instead:

 

```diff
-    fs.insert("dist".into(), "".as_bytes());
+    fs.insert("dist/index.js".into(), b"");

This mirrors real projects better and aligns MemoryFS with OS semantics.

crates/biome_cli/src/commands/init.rs (2)

23-34: Consider broadening generated-folder detection

Today only “dist” is handled. You might want a small list (e.g. build, out, coverage, .next, public, target) and generate corresponding double-excludes.

Happy to draft a tiny helper that builds includes = ["**", ...excludes].

---

47-51: Prefer Console.message/diagnostic for consistency

You’re logging a diagnostic via PrintDiagnostic inside log(). For consistency with biome_console usage, prefer message() for plain markup or diagnostic() for diagnostics output.

Example:

session.app.console.message(markup! { {PrintDiagnostic::simple(&diagnostic)} });

Based on learnings.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-10-02T12:58:46.845Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/language.rs : Create `HtmlTestFormatLanguage` and implement the `TestFormatLanguage` trait

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-10-02T12:58:46.845Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/spec_tests.rs : Configure test generation using `tests_macros::gen_tests! {"tests/specs/html/**/*.html", crate::spec_test::run, ""}` inside a formatter::html_module module

Learnt from: CR
PR: biomejs/biome#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-17T08:55:30.118Z
Learning: Applies to crates/biome_html_formatter/benches/html_formatter.rs : Maintain the HTML formatter benchmark at benches/html_formatter.rs within the biome_html_formatter crate

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-10-02T12:58:46.845Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/spec_test.rs : Provide a `run` function that builds a SpecSnapshot with HtmlFormatLanguage and HtmlTestFormatLanguage and calls `snapshot.test()`

crates/biome_cli/tests/commands/format.rs (1)

3432-3432: Test name no longer matches behaviour

The test asserts an error by default. Consider renaming to html_disabled_by_default to avoid confusion.

crates/biome_fs/src/fs/memory.rs (1)

203-206: Make path_exists detect directories too

Current implementation returns true only for files. To align with typical “exists” semantics (file or directory), consider delegating to path_kind:

-    fn path_exists(&self, path: &Utf8Path) -> bool {
-        let files = self.files.0.read();
-        files.contains_key(path)
-    }
+    fn path_exists(&self, path: &Utf8Path) -> bool {
+        self.path_kind(path).is_ok()
+    }

This keeps tests working and makes dist/ checks more realistic.

crates/biome_configuration/src/vcs.rs (1)

68-76: Add rustdoc for the new public constructor

new_git_ignore is a public convenience API; please add a brief rustdoc explaining intent and defaults it sets.

As per coding guidelines

crates/biome_cli/tests/commands/init.rs (1)

43-61: Simulate dist as a directory for realism

To better mirror real projects, insert a file under dist (e.g. dist/index.js) rather than a bare "dist" entry. This will continue to pass if MemoryFileSystem::path_exists is later upgraded to detect directories.

crates/biome_cli/src/commands/init.rs (2)

23-34: Glob pattern and unwraps

• Consider using expect(...) over unwrap() to aid debugging if patterns ever change.
• Please confirm that "!!/dist" excludes files under dist as intended; if the grammar expects a directory glob, "!!/dist/**" may be clearer.

-                "**".parse::<biome_glob::NormalizedGlob>().unwrap(),
-                "!!**/dist".parse::<biome_glob::NormalizedGlob>().unwrap(),
+                "**"
+                    .parse::<biome_glob::NormalizedGlob>()
+                    .expect("hard-coded glob must be valid"),
+                "!!**/dist"
+                    .parse::<biome_glob::NormalizedGlob>()
+                    .expect("hard-coded glob must be valid"),

If the engine requires a directory suffix, switch to "!!/dist/".

---

80-121: Minor copy tweaks in the init message

Polish the UX copy:

• “Setup an editor extension” → “Set up an editor extension”.
• “Seek for help on Discord” → “Seek help on Discord”.

-  "<Dim>"1."</Dim>" "<Emphasis>"Setup an editor extension"</Emphasis>"
+  "<Dim>"1."</Dim>" "<Emphasis>"Set up an editor extension"</Emphasis>"
@@
-     Seek for help on Discord: "<Hyperlink href="https://biomejs.dev/chat">"https://biomejs.dev/chat"</Hyperlink>"
+     Seek help on Discord: "<Hyperlink href="https://biomejs.dev/chat">"https://biomejs.dev/chat"</Hyperlink>"

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-10-02T12:58:46.845Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/spec_tests.rs : Configure test generation using `tests_macros::gen_tests! {"tests/specs/html/**/*.html", crate::spec_test::run, ""}` inside a formatter::html_module module

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-10-02T12:58:46.845Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/language.rs : Create `HtmlTestFormatLanguage` and implement the `TestFormatLanguage` trait

Learnt from: CR
PR: biomejs/biome#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-17T08:55:30.118Z
Learning: Applies to crates/biome_html_formatter/benches/html_formatter.rs : Maintain the HTML formatter benchmark at benches/html_formatter.rs within the biome_html_formatter crate

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-10-02T12:58:46.845Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/spec_test.rs : Provide a `run` function that builds a SpecSnapshot with HtmlFormatLanguage and HtmlTestFormatLanguage and calls `snapshot.test()`