Skip to content

feat: promote lint rules #7758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ematipico merged 11 commits into from
Oct 22, 2025
Merged

feat: promote lint rules #7758

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7526668
feat: promote lint rules
ematipico Oct 15, 2025
e8d858a
[autofix.ci] apply automated fixes
autofix-ci[bot] Oct 15, 2025
5e7cb73
fix tests
ematipico Oct 15, 2025
035d608
linting
ematipico Oct 15, 2025
821e59c
merge with main
ematipico Oct 15, 2025
f8dc8cc
fix lint rules
ematipico Oct 15, 2025
66be346
feedback
ematipico Oct 15, 2025
20cd1e3
fix tests
ematipico Oct 16, 2025
cec9553
update snapshot
ematipico Oct 20, 2025
4505ec1
chore: update severity
ematipico Oct 20, 2025
cdd38c0
Merge remote-tracking branch 'origin/next' into feat/promote-rules-230
ematipico Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@ematipico
ematipico committed Oct 20, 2025
commit 20cd1e3b6589526e08f793abeccbd388bbf4c48f
47 changes: 47 additions & 0 deletions crates/biome_js_analyze/tests/specs/security/noSecrets/invalid_entropy_high.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,53 @@ const privateKey3 = "K7!mP9$qR2#nX5&vL8*yT4^uH6%wB3+gC1~zF0@jM7-eI9#kQ2$pL5";
```

# Diagnostics
```
invalid_entropy_high.options:7:17 deserialize ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Found an unknown key `noSecrets`.

5 │ "rules": {
6 │ "nursery": {
> 7 │ "noSecrets": {
│ ^^^^^^^^^^^
8 │ "level": "error",
9 │ "options": {

i Known keys:

- recommended
- noDeprecatedImports
- noDuplicateDependencies
- noEmptySource
- noFloatingPromises
- noImportCycles
- noJsxLiterals
- noMisusedPromises
- noNextAsyncClientComponent
- noReactForwardRef
- noShadow
- noUnnecessaryConditions
- noUnresolvedImports
- noUnusedExpressions
- noUselessCatchBinding
- noUselessUndefined
- noVueDataObjectDeclaration
- noVueDuplicateKeys
- noVueReservedKeys
- noVueReservedProps
- useConsistentArrowReturn
- useDeprecatedDate
- useExhaustiveSwitchCases
- useExplicitType
- useMaxParams
- useQwikMethodUsage
- useQwikValidLexicalScope
- useSortedClasses
- useVueMultiWordComponentNames


```

```
invalid_entropy_high.js:2:22 lint/security/noSecrets ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Expand Down
47 changes: 47 additions & 0 deletions crates/biome_js_analyze/tests/specs/security/noSecrets/invalid_entropy_low.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,53 @@ const mediumEntropy4 = "TokenXyZ98765";
```

# Diagnostics
```
invalid_entropy_low.options:7:17 deserialize ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Found an unknown key `noSecrets`.

5 │ "rules": {
6 │ "nursery": {
> 7 │ "noSecrets": {
│ ^^^^^^^^^^^
8 │ "level": "error",
9 │ "options": {

i Known keys:

- recommended
- noDeprecatedImports
- noDuplicateDependencies
- noEmptySource
- noFloatingPromises
- noImportCycles
- noJsxLiterals
- noMisusedPromises
- noNextAsyncClientComponent
- noReactForwardRef
- noShadow
- noUnnecessaryConditions
- noUnresolvedImports
- noUnusedExpressions
- noUselessCatchBinding
- noUselessUndefined
- noVueDataObjectDeclaration
- noVueDuplicateKeys
- noVueReservedKeys
- noVueReservedProps
- useConsistentArrowReturn
- useDeprecatedDate
- useExhaustiveSwitchCases
- useExplicitType
- useMaxParams
- useQwikMethodUsage
- useQwikValidLexicalScope
- useSortedClasses
- useVueMultiWordComponentNames


```

```
invalid_entropy_low.js:2:24 lint/security/noSecrets ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Expand Down
7 changes: 4 additions & 3 deletions .../biome_js_analyze/tests/specs/style/useConsistentTypeDefinitions/invalidType.options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
{
"$schema": "../../../../../../backend-jsonrpc/src/workspace.schema.json",
"$schema": "../../../../../../packages/@biomejs/biome/configuration_schema.json",
"linter": {
"rules": {
"nursery": {
"style": {
"useConsistentTypeDefinitions": {
"level": "on",
"options": {
"style": "type"
}
}
}
}
}
}
}
199 changes: 199 additions & 0 deletions crates/biome_js_analyze/tests/specs/style/useConsistentTypeDefinitions/invalidType.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,202 @@ type Union = { a: string } | { b: number };
type Intersection = { a: string } & { b: number };
type StringAlias = string;
```

# Diagnostics
```
invalidType.ts:2:1 lint/style/useConsistentTypeDefinitions FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Use of the interface detected.

1 │ // Option: prefer type
> 2 │ interface Foo {
│ ^^^^^^^^^^^^^^^
> 3 │ prop: string;
> 4 │ }
│ ^
5 │
6 │ interface Bar {

i The codebase should use a consistent coding style for the definition of types. This improves the readability and consistency.

i Unsafe fix: Use type alias.

1 1 │ // Option: prefer type
2 │ - interface·Foo·{
2 │ + type·Foo·=·{
3 3 │ prop: string;
4 │ - }
4 │ + };
5 5 │
6 6 │ interface Bar {


```

```
invalidType.ts:6:1 lint/style/useConsistentTypeDefinitions FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Use of the interface detected.

4 │ }
5 │
> 6 │ interface Bar {
│ ^^^^^^^^^^^^^^^
> 7 │ method(): void;
> 8 │ }
│ ^
9 │
10 │ interface Point {

i The codebase should use a consistent coding style for the definition of types. This improves the readability and consistency.

i Unsafe fix: Use type alias.

4 4 │ }
5 5 │
6 │ - interface·Bar·{
6 │ + type·Bar·=·{
7 7 │ method(): void;
8 │ - }
8 │ + };
9 9 │
10 10 │ interface Point {


```

```
invalidType.ts:10:1 lint/style/useConsistentTypeDefinitions FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Use of the interface detected.

8 │ }
9 │
> 10 │ interface Point {
│ ^^^^^^^^^^^^^^^^^
> 11 │ x: number;
> 12 │ y: number;
> 13 │ }
│ ^
14 │
15 │ interface User {

i The codebase should use a consistent coding style for the definition of types. This improves the readability and consistency.

i Unsafe fix: Use type alias.

8 8 │ }
9 9 │
10 │ - interface·Point·{
10 │ + type·Point·=·{
11 11 │ x: number;
12 12 │ y: number;
13 │ - }
13 │ + };
14 14 │
15 15 │ interface User {


```

```
invalidType.ts:15:1 lint/style/useConsistentTypeDefinitions FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Use of the interface detected.

13 │ }
14 │
> 15 │ interface User {
│ ^^^^^^^^^^^^^^^^
> 16 │ name: string;
> 17 │ age: number;
> 18 │ }
│ ^
19 │
20 │ interface Config {

i The codebase should use a consistent coding style for the definition of types. This improves the readability and consistency.

i Unsafe fix: Use type alias.

13 13 │ }
14 14 │
15 │ - interface·User·{
15 │ + type·User·=·{
16 16 │ name: string;
17 17 │ age: number;
18 │ - }
18 │ + };
19 19 │
20 20 │ interface Config {


```

```
invalidType.ts:20:1 lint/style/useConsistentTypeDefinitions FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Use of the interface detected.

18 │ }
19 │
> 20 │ interface Config {
│ ^^^^^^^^^^^^^^^^^^
> 21 │ apiUrl: string;
> 22 │ timeout: number;
> 23 │ retries: number;
> 24 │ }
│ ^
25 │
26 │ interface /* comment 1 */ Comments /* comment 2 */ { /* comment 3 */

i The codebase should use a consistent coding style for the definition of types. This improves the readability and consistency.

i Unsafe fix: Use type alias.

18 18 │ }
19 19 │
20 │ - interface·Config·{
20 │ + type·Config·=·{
21 21 │ apiUrl: string;
22 22 │ timeout: number;
23 23 │ retries: number;
24 │ - }
24 │ + };
25 25 │
26 26 │ interface /* comment 1 */ Comments /* comment 2 */ { /* comment 3 */


```

```
invalidType.ts:26:1 lint/style/useConsistentTypeDefinitions FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Use of the interface detected.

24 │ }
25 │
> 26 │ interface /* comment 1 */ Comments /* comment 2 */ { /* comment 3 */
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 27 │ /* comment 4 */ lorem:/* comment 5 */ boolean/* comment 6 */
> 28 │ /* comment 7 */ }
│ ^^^^^^^^^^^^^^^^^
29 │
30 │ // These should not trigger errors as interfaces cannot represent these

i The codebase should use a consistent coding style for the definition of types. This improves the readability and consistency.

i Unsafe fix: Use type alias.

24 24 │ }
25 25 │
26 │ - interface·/*·comment·1·*/·Comments·/*·comment·2·*/·{·/*·comment·3·*/
26 │ + type·Comments·/*·comment·2·*/·=·{·/*·comment·3·*/
27 27 │ /* comment 4 */ lorem:/* comment 5 */ boolean/* comment 6 */
28 │ - /*·comment·7·*/·}
28 │ + /*·comment·7·*/·};
29 29 │
30 30 │ // These should not trigger errors as interfaces cannot represent these


```
7 changes: 4 additions & 3 deletions ...es/biome_js_analyze/tests/specs/style/useConsistentTypeDefinitions/validType.options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
{
"$schema": "../../../../../../backend-jsonrpc/src/workspace.schema.json",
"$schema": "../../../../../../packages/@biomejs/biome/configuration_schema.json",
"linter": {
"rules": {
"nursery": {
"style": {
"useConsistentTypeDefinitions": {
"level": "on",
"options": {
"style": "type"
}
}
}
}
}
}
}
Loading