Skip to content

chore: update Unicode table for Unicode 17 #7546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2025
Merged

chore: update Unicode table for Unicode 17 #7546

merged 2 commits into from
Sep 21, 2025

Conversation

@siketyan
Copy link
Member

@siketyan siketyan commented Sep 21, 2025 •
edited
Loading

Summary

Unicode 17.0.0 has been published and DerivedCoreProperties.txt is now updated. I ran cargo run -p xtask_codegen -- unicode to update the table.

Test Plan

N/A

Docs

N/A

@siketyan siketyan requested review from a team September 21, 2025 05:24
@siketyan siketyan self-assigned this Sep 21, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e07b41b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ematipico
ematipico approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should at least add a patch changeset

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 21, 2025

Walkthrough

Updates internal Unicode string data to Unicode 17.0 and marks the @biomejs/biome dependency as a patch update. No code or public API changes; this is a data/versioning adjustment only.

Suggested labels

A-Formatter

Suggested reviewers

  • dyc3
  • ematipico

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "chore: update Unicode table for Unicode 17" succinctly and accurately reflects the primary change—updating the repository's Unicode data to Unicode 17.0.0—so it is concise, on-topic and useful for teammates scanning history.
Description Check ✅ Passed The description clearly states that DerivedCoreProperties.txt was updated for Unicode 17.0.0 and that the codegen command was run, which directly corresponds to the changeset and is therefore on-topic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-unicode-table

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Sep 21, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/shaky-swans-brake.md (1)

5-5: Tighten the prose to match changeset guidelines (past tense + present behaviour).

Use past tense for the change and present tense for current behaviour. Suggestion below.

-Internal data for Unicode strings have been updated to Unicode 17.0.
+Updated internal Unicode string tables to Unicode 17.0.
+Biome now reflects the Unicode 17.0 Derived Core Properties.

Optional: add a tiny code snippet if there’s a user‑visible behaviour change worth illustrating.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a4f4fc and e07b41b.

⛔ Files ignored due to path filters (1)
  • crates/biome_unicode_table/src/tables.rs is excluded by !**/biome_unicode_table/src/tables.rs and included by **
📒 Files selected for processing (1)
  • .changeset/shaky-swans-brake.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

.changeset/*.md: In changeset files, only use #### or ##### headers; avoid other header levels
Changeset descriptions should use past tense for what you did (e.g., "Added...")
Describe current Biome behavior in present tense within changesets (e.g., "Biome now supports...")
For bug fixes in changesets, start with a link to the issue (e.g., "Fixed #1234: ...")
When referencing rules or assists in changesets, include links to their documentation pages
Include a minimal code block in the changeset when applicable to demonstrate the change
End every sentence in the changeset description with a period

Files:

  • .changeset/shaky-swans-brake.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: autofix
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Documentation
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Check Dependencies
  • GitHub Check: Test Node.js API
🔇 Additional comments (1)
.changeset/shaky-swans-brake.md (1)

1-3: Front‑matter looks good for a patch bump.

Version impact is correctly scoped to @biomejs/biome as a patch.

@siketyan siketyan merged commit a683acc into main Sep 21, 2025
13 checks passed
@siketyan siketyan deleted the chore/update-unicode-table branch September 21, 2025 06:50
@github-actions github-actions bot mentioned this pull request Sep 20, 2025
Merged
kedevked pushed a commit to kedevked/biome that referenced this pull request Sep 22, 2025
@siketyan @kedevked
chore: update Unicode table for Unicode 17 (biomejs#7546)
e80b45d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ematipico ematipico ematipico approved these changes

Assignees

@siketyan siketyan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siketyan @ematipico