chore: add .oxlintrc.json to well-known files #7536

TheAlexLichter · 2025-09-18T19:13:08Z

Summary

Adds .oxlintrc.json to well-known files to allow proper formatting.

Resolves #7448

changeset-bot · 2025-09-18T19:13:13Z

🦋 Changeset detected

Latest commit: 53f3c58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages

Name	Type
@biomejs/biome	Minor
@biomejs/cli-win32-x64	Minor
@biomejs/cli-win32-arm64	Minor
@biomejs/cli-darwin-x64	Minor
@biomejs/cli-darwin-arm64	Minor
@biomejs/cli-linux-x64	Minor
@biomejs/cli-linux-arm64	Minor
@biomejs/cli-linux-x64-musl	Minor
@biomejs/cli-linux-arm64-musl	Minor
@biomejs/wasm-web	Minor
@biomejs/wasm-bundler	Minor
@biomejs/wasm-nodejs	Minor
@biomejs/backend-jsonrpc	Patch
@biomejs/js-api	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ematipico

This PR must be merged to next, and it needs a changeset (minor)

.changeset/polite-pets-serve.md

coderabbitai · 2025-09-19T06:33:31Z

Walkthrough

The PR adds a changeset at .changeset/polite-pets-serve.md declaring a minor release for @biomejs/biome and documenting the inclusion of .oxlintrc.json in the well-known files list. In crates/biome_json_syntax/src/file_source.rs, .oxlintrc.json is added to WELL_KNOWN_JSON_ALLOW_COMMENTS_AND_TRAILING_COMMAS_FILES, aligning it with files parsed using json-strip-comments (which also removes trailing commas). No public APIs or declarations are modified.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "chore: add .oxlintrc.json to well-known files" is concise, uses a conventional "chore:" prefix, and directly summarises the primary change (adding .oxlintrc.json to the well‑known files list), so it accurately reflects the changeset.
Description Check	✅ Passed	The description clearly states the intent (adding .oxlintrc.json to well‑known files to enable formatting) and links the related discussion, so it is on‑topic and satisfies the lenient description check.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b13e524 and 53f3c58.

⛔ Files ignored due to path filters (1)

crates/biome_configuration/src/generated/domain_selector.rs is excluded by !**/generated/**, !**/generated/** and included by **

📒 Files selected for processing (2)

.changeset/polite-pets-serve.md (1 hunks)
crates/biome_json_syntax/src/file_source.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

.changeset/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

.changeset/*.md: In changeset files, only use #### or ##### headers; avoid other header levels
Changeset descriptions should use past tense for what you did (e.g., "Added...")
Describe current Biome behavior in present tense within changesets (e.g., "Biome now supports...")
For bug fixes in changesets, start with a link to the issue (e.g., "Fixed #1234: ...")
When referencing rules or assists in changesets, include links to their documentation pages
Include a minimal code block in the changeset when applicable to demonstrate the change
End every sentence in the changeset description with a period

Files:

.changeset/polite-pets-serve.md

crates/biome_*_{syntax,parser,formatter,analyze,factory,semantic}/**

📄 CodeRabbit inference engine (CLAUDE.md)

Maintain the per-language crate structure: biome_{lang}_{syntax,parser,formatter,analyze,factory,semantic}

Files:

crates/biome_json_syntax/src/file_source.rs

crates/biome_*/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place core crates under /crates/biome_*/

Files:

crates/biome_json_syntax/src/file_source.rs

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Format all Rust source files before committing (just f)

Files:

crates/biome_json_syntax/src/file_source.rs

🔇 Additional comments (2)

.changeset/polite-pets-serve.md (1)

5-5: Changeset text meets the house style — LGTM.

Past tense, succinct, and ends with a period. Front‑matter looks correct for a minor bump.

crates/biome_json_syntax/src/file_source.rs (1)

135-139: .oxlintrc.json correctly classified and alphabetically placed — nice one.

The entry keeps the slice sorted and matches the “comments + trailing commas” bucket; the inline links are helpful.

Quick sanity check: does oxc also recognise a bare “.oxlintrc” (no extension)? If yes, we should add it to the same list to keep behaviour consistent.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed-hq · 2025-09-20T05:41:35Z

CodSpeed Performance Report

Merging #7536 will not alter performance

_{Comparing TheAlexLichter:chore/add-oxlint-as-well-known-file (53f3c58) with next (b13e524)}

Summary

✅ 133 untouched

github-actions bot added A-Parser Area: parser L-JSON Language: JSON and super languages labels Sep 18, 2025

dyc3 approved these changes Sep 18, 2025

View reviewed changes

TheAlexLichter mentioned this pull request Sep 18, 2025

chore: add .oxlintrc.json as well-known file biomejs/website#3124

Merged

ematipico reviewed Sep 18, 2025

View reviewed changes

ematipico changed the base branch from main to next September 18, 2025 20:21

github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis L-Grit Language: GritQL labels Sep 18, 2025

TheAlexLichter force-pushed the chore/add-oxlint-as-well-known-file branch from ab6966b to 171c760 Compare September 18, 2025 20:58

chore: add .oxlintrc.json to well-known files

8285f22

TheAlexLichter force-pushed the chore/add-oxlint-as-well-known-file branch from 171c760 to 8285f22 Compare September 18, 2025 20:59

github-actions bot removed A-Project Area: project A-Linter Area: linter A-Tooling Area: internal tools A-Diagnostic Area: diagnostocis L-Grit Language: GritQL labels Sep 18, 2025

TheAlexLichter and others added 2 commits September 18, 2025 17:00

chore: add changeset

d833fb4

[autofix.ci] apply automated fixes

b563fa7

github-actions bot added the A-Project Area: project label Sep 18, 2025

ematipico approved these changes Sep 19, 2025

View reviewed changes

.changeset/polite-pets-serve.md Outdated Show resolved Hide resolved

Update .changeset/polite-pets-serve.md

53f3c58

ematipico merged commit 0bccd34 into biomejs:next Sep 20, 2025
29 checks passed

TheAlexLichter deleted the chore/add-oxlint-as-well-known-file branch September 20, 2025 09:37

github-actions bot mentioned this pull request Oct 23, 2025

ci: release #7824

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: add .oxlintrc.json to well-known files #7536

chore: add .oxlintrc.json to well-known files #7536

Uh oh!

TheAlexLichter commented Sep 18, 2025

Uh oh!

changeset-bot bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

ematipico left a comment •

edited

Loading

Uh oh!

Uh oh!

coderabbitai bot commented Sep 19, 2025

Uh oh!

codspeed-hq bot commented Sep 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

chore: add .oxlintrc.json to well-known files #7536

chore: add .oxlintrc.json to well-known files #7536

Uh oh!

Conversation

TheAlexLichter commented Sep 18, 2025

Summary

Uh oh!

changeset-bot bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

ematipico left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot commented Sep 19, 2025

Walkthrough

Pre-merge checks and finishing touches

Uh oh!

codspeed-hq bot commented Sep 20, 2025

CodSpeed Performance Report

Merging #7536 will not alter performance

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Sep 18, 2025 •

edited

Loading

ematipico left a comment •

edited

Loading