Skip to content

fix(css): allow navigation property for view-transition (fixes #7340) #7352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

fix(css): allow navigation property for view-transition (fixes #7340) #7352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
673d5b2
fix(noDuplicateObjectKeys): correct grammatical error in JSON diagnos…
JeetuSuthar Aug 24, 2025
8447596
remove changeset as suggested by reviewer
JeetuSuthar Aug 24, 2025
faeedc7
fix(css): allow navigation property for view-transition (fixes #7340)
JeetuSuthar Aug 28, 2025
955b1db
Delete crates/biome_json_analyze/tests/specs/suspicious/noDuplicateOb…
JeetuSuthar Aug 28, 2025
b8a9211
Delete crates/biome_cli/tests/snapshots/main_commands_lint/check_json…
JeetuSuthar Aug 28, 2025
663426b
Delete crates/biome_cli/tests/snapshots/main_commands_check/check_jso…
JeetuSuthar Aug 28, 2025
af97d7f
Delete crates/biome_json_analyze/src/lint/suspicious/no_duplicate_obj…
JeetuSuthar Aug 28, 2025
ff39272
fix(css): maintain sorted order for navigation property in KNOWN_PROP…
JeetuSuthar Aug 28, 2025
f0cf1c2
restore files needed for clean cherry-pick
JeetuSuthar Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/keep-jsxeverywhere-variant.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@biomejs/biome": patch
---

Fixed [#7286](https://github.com/biomejs/biome/issues/7286). Files are now formatted with JSX behavior when `javascript.parser.jsxEverywhere` is explicitly set.

Previously, this flag was only used for parsing, but not for formatting, which resulted in incorrect formatting of conditional expressions when JSX syntax is used in `.js` files.
Comment on lines +1 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Changeset appears unrelated to this PR and misses a trailing full stop.

This PR targets CSS “navigation” property support; this changeset is about JSX-everywhere formatting and links #7286. Either move it to the relevant PR or adjust the content. Also, per repo guidelines, end sentences with a period.

🤖 Prompt for AI Agents 
In .changeset/keep-jsxeverywhere-variant.md around lines 1 to 7, the changeset's
content is unrelated to this PR (it documents JSX-everywhere formatting and
links #7286) and the text is missing a trailing period; either remove or move
this changeset into the PR that fixes issue #7286 (or create a new PR that
includes it), or rewrite the changeset to reflect the actual CSS “navigation”
change this PR implements, and ensure all sentences end with a period and follow
repo changeset guidelines.

18 changes: 18 additions & 0 deletions .changeset/use_readonly_class_properties_nested_assignment_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
"@biomejs/biome": patch
---

Fixed [#7310](https://github.com/biomejs/biome/issues/7310): [`useReadonlyClassProperties`](https://biomejs.dev/linter/rules/use-readonly-class-properties/) correctly handles nested assignments, avoiding false positives when a class property is assigned within another assignment expression.

Example of code that previously triggered a false positive but is now correctly ignored:

```ts
class test {
private thing: number = 0; // incorrectly flagged

public incrementThing(): void {
const temp = {x: 0};
temp.x = this.thing++;
}
}
```
Comment on lines +1 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Changeset content does not match this PR’s scope (navigation property). Replace with a changeset for noUnknownProperty.

This PR fixes a CSS false positive for navigation, but the changeset documents an unrelated rule and issue (#7310). Please align the changeset with issue #7340 and the rule lint/correctness/noUnknownProperty.

Proposed replacement:

---
-"@biomejs/biome": patch
----
-
-Fixed [#7310](https://github.com/biomejs/biome/issues/7310): [`useReadonlyClassProperties`](https://biomejs.dev/linter/rules/use-readonly-class-properties/) correctly handles nested assignments, avoiding false positives when a class property is assigned within another assignment expression.
-
-Example of code that previously triggered a false positive but is now correctly ignored:
-
-```ts
-class test {
-  private thing: number = 0; // incorrectly flagged
-
-  public incrementThing(): void {
-    const temp = {x: 0};
-    temp.x = this.thing++;
-  }
-}
-```
+ "@biomejs/biome": patch
+---
+
+Fixed [#7340](https://github.com/biomejs/biome/issues/7340): `noUnknownProperty` recognises the CSS `navigation` property from the View Transitions spec, avoiding false positives.
+
+Example (valid, no diagnostics):
+
+```css
+.card {
+  navigation: auto;
+}
+```

I can also open a new changeset file with the correct name and remove this one if you prefer.

2 changes: 1 addition & 1 deletion .github/workflows/beta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
sudo apt-get install -y musl-tools

- name: Install cargo-audit
uses: taiki-e/install-action@ad95d4e02e061d4390c4b66ef5ed56c7fee3d2ce # v2.58.17
uses: taiki-e/install-action@f63c33fd96cc1e69a29bafd06541cf28588b43a4 # v2.58.21
if: matrix.code-target == 'linux-x64-musl'
with:
tool: cargo-audit
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Run tests on ${{ matrix.os }}
run: cargo test --workspace
run: cargo test --workspace --features=js_plugin

coverage:
name: Test262 Coverage
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
sudo apt-get install -y musl-tools

- name: Install cargo-audit
uses: taiki-e/install-action@ad95d4e02e061d4390c4b66ef5ed56c7fee3d2ce # v2.58.17
uses: taiki-e/install-action@f63c33fd96cc1e69a29bafd06541cf28588b43a4 # v2.58.21
if: matrix.code-target == 'linux-x64-musl'
with:
tool: cargo-audit
Expand All @@ -73,7 +73,7 @@ jobs:

# Build the CLI binary
- name: Build binaries
run: cargo build -p biome_cli --release --target ${{ matrix.target }}
run: cargo build -p biome_cli --release --target=${{ matrix.target }} --features=js_plugin
env:
# Strip all debug symbols from the resulting binaries
RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:

# Build the CLI binary
- name: Build binaries
run: cargo build -p biome_cli --release --target ${{ matrix.target }}
run: cargo build -p biome_cli --release --target=${{ matrix.target }} --features=js_plugin
env:
# Strip all debug symbols from the resulting binaries
RUSTFLAGS: "-C strip=symbols -C codegen-units=1"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Run tests
run: cargo test --workspace
run: cargo test --workspace --features=js_plugin

e2e-tests:
name: End-to-end tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ jobs:
sudo apt-get install -y musl-tools

- name: Install cargo-audit
uses: taiki-e/install-action@ad95d4e02e061d4390c4b66ef5ed56c7fee3d2ce # v2.58.17
uses: taiki-e/install-action@f63c33fd96cc1e69a29bafd06541cf28588b43a4 # v2.58.21
if: matrix.code-target == 'linux-x64-musl'
with:
tool: cargo-audit
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release_cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
run: echo "nightly=true" >> $GITHUB_ENV

- name: Check version changes
uses: EndBug/version-check@36ff30f37c7deabe56a30caa043d127be658c425 # v2.1.5
uses: EndBug/version-check@5102328418c0130d66ca712d755c303e93368ce2 # v2.1.7
id: version
with:
diff-search: true
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
sudo apt-get install -y musl-tools

- name: Install cargo-audit
uses: taiki-e/install-action@ad95d4e02e061d4390c4b66ef5ed56c7fee3d2ce # v2.58.17
uses: taiki-e/install-action@f63c33fd96cc1e69a29bafd06541cf28588b43a4 # v2.58.21
if: matrix.code-target == 'linux-x64-musl'
with:
tool: cargo-audit
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release_js_api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
run: echo "nightly=true" >> $GITHUB_ENV

- name: Check version changes
uses: EndBug/version-check@36ff30f37c7deabe56a30caa043d127be658c425 # v2.1.5
uses: EndBug/version-check@5102328418c0130d66ca712d755c303e93368ce2 # v2.1.7
if: env.nightly != 'true'
id: version
with:
Expand Down
Loading
Loading