crates/biome_js_analyze/src/lint/style/use_exponentiation_operator.rs (3)

154-158: Wrap-the-child approach is spot on; tiny simplification available

You can avoid the if let Some(true) pattern and read a little cleaner with unwrap_or(false) (semantics unchanged, as the helper never returns Some(false)).

-        let new_node = if let Some(true) = does_exponentiation_expression_need_parens(node) {
+        let new_node = if does_exponentiation_expression_need_parens(node).unwrap_or(false) {
             make::parenthesized(new_node).into()
         } else {
             new_node
         };

---

173-177: Rustdoc is now misleading; update to reflect the new behaviour and contract

The function no longer mutates parents and its return type/meaning changed. Let’s align the docs.

-/// Determines whether the given parent node needs parens if used as the exponent in an exponentiation binary expression.
+/// Determines whether the newly formed exponentiation expression should be parenthesised
+/// in the current parent context of the original `Math.pow` call.
+/// Returns `Some(true)` iff extra parentheses are required; otherwise `None`
+/// (including when no parentheses are needed or when there is no relevant parent).

---

176-193: Confirm Option contract and cover edge contexts with tests

The helper currently returns only Some(true) or None. That contract makes the call-site check correct, but please confirm this is intentional and stable.

Also, worth verifying snapshots for contexts most sensitive to precedence/grammar:

• class Foo extends Math.pow(A, B) {}
• class extends Math.pow(A, B) {}
• Math.pow(a, b).toString()
• obj[Math.pow(a, b)]
• Math.pow(a, b) in obj
• typeof Math.pow(a, b)

Happy to draft focused tests if you want.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_js_analyze/lib/src/lint/nursery/*.rs : For new JavaScript lint rules generated by `just new-js-lintrule`, implement the rule in the generated file under `biome_js_analyze/lib/src/lint/nursery/`

crates/biome_js_analyze/src/lint/style/use_exponentiation_operator.rs (1)

173-191: Docstring now misleads; it mentions a “parent node”.

The helper returns whether the replacement needs parens in this context, not which parent to rewrite. Tighten the comment.

-/// Determines whether the given parent node needs parens if used as the exponent in an exponentiation binary expression.
+/// Determines whether the newly created exponentiation expression needs parentheses
+/// in the current context of this `Math.pow(...)` call.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.