crates/biome_js_analyze/tests/specs/correctness/noUnusedImports/issue_6835.tsx (1)

1-7: Consider mirroring the original repro more closely (qualified type use).

The issue used a qualified reference (e.g. Parameters<ns.Member>[0]). Using the bare namespace as a type argument is atypical in TS and may not reflect real-world usage. Recommend adding a qualified member case to ensure the semantic events also cover ns.Member in type position.

Would you like me to add an extra assertion-only test that references a qualified name (e.g. type T = Parameters<postcssModules.SomeFn>[0] or type U = postcssModules.SomeType) so we exercise both forms?

crates/biome_js_analyze/tests/quick_test.rs (1)

32-39: Tiny consistency nit: use .tsx extension to match JsFileSource::tsx().

You parse as TSX; make the filename extension match for fewer head-scratches later.

-    const FILENAME: &str = "dummyFile.ts";
+    const FILENAME: &str = "dummyFile.tsx";

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:50:12.090Z
Learning: Applies to crates/biome_js_type_info/src/**/*.rs : Use TypeData::Unknown for unimplemented inference and TypeData::UnknownKeyword for the explicit TypeScript unknown keyword; treat them semantically the same but keep them distinct for measurement

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:50:12.090Z
Learning: Applies to crates/biome_js_type_info/biome_module_graph/src/js_module_info/collector.rs : Thin (module-level) inference may resolve qualifiers to local declarations or globals (TypeReference::Resolved), mark imported bindings as TypeReference::Import, and set unresolved to TypeReference::Unknown; it must not look beyond the current module

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_js_analyze/tests/quick_test.rs : Use `biome_js_analyze/tests/quick_test.rs` for quick, ad-hoc testing; un-ignore the test and adjust the rule filter as needed

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_rule_options/lib/**/*.rs : Define per-rule options in the `biome_rule_options` crate under `lib/`, with serde- and schemars-compatible derives and `#[serde(rename_all = "camelCase", deny_unknown_fields, default)]`

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_js_analyze/lib/src/lint/nursery/*.rs : For new JavaScript lint rules generated by `just new-js-lintrule`, implement the rule in the generated file under `biome_js_analyze/lib/src/lint/nursery/`

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/spec_test.rs : Create tests/spec_test.rs implementing the run(spec_input_file, _expected_file, test_directory, _file_type) function as shown and include!("language.rs")

crates/biome_js_analyze/src/lint/correctness/no_unused_imports.rs (3)

129-131: Typo fix looks good — consistent rename to Visitor.

The struct name correction to JsDocTypeCollectorVisitor is tidy and improves clarity.

---

137-157: Impl matches the rename; no behavioural change.

Consistent with the struct rename; finish hook still wires JsDocTypeModel into services as before.

---

245-252: Visitor wiring order is sensible.

Adding JsDocTypeCollectorVisitor in the Syntax phase after SemanticModelBuilderVisitor keeps JSDoc harvesting cheap and independent. No objections.

crates/biome_js_semantic/src/events.rs (1)

646-655: Verification of double-report risk for extra Read + UnresolvedReference events

I ran your grep across all lint rules in crates/biome_js_analyze/src/lint and found these that consume all_references or match on UnresolvedReference:

• correctness/no_unused_imports.rs
• correctness/no_unused_variables.rs
• correctness/no_unused_function_parameters.rs
• complexity/no_useless_this_alias.rs
• correctness/no_react_prop_assignments.rs
• correctness/no_unused_private_class_members.rs
• correctness/no_invalid_use_before_declaration.rs
• style/use_for_of.rs
• style/use_import_type.rs
• style/use_const.rs
• style/no_shouty_constants.rs

Quick take:

• no_unused_imports only does binding.all_references(model).next().is_none(), so it won’t double-report (it merely checks for any reference)
• The other rules apply filters (.is_read(), AST parent checks, .count() > 1, .is_only_type(), range comparisons, etc.), which should either ignore UnresolvedReference or collapse multiple events

However, given the variety of filters, I recommend a quick manual check in each rule to ensure they:

1. Don’t inadvertently count both the HoistedRead and the UnresolvedReference as separate usages
2. Properly filter out type-only UnresolvedReference events when irrelevant

Also, the inline nitpick comment you suggested can be applied verbatim:

                     if type_token.is_none() {
                         self.push_binding(None, BindingName::Value(name.clone()), info.clone());
+                        // Also record a Type binding so type-only references to the namespace
+                        // (e.g. in `Parameters<ns>` or `ns.Member`) count as usages for lints
+                        // like `noUnusedImports`. `pop_scope` still emits an UnresolvedReference
+                        // for `ns`-as-type to preserve other diagnostics.
                         self.push_binding(None, BindingName::Type(name.clone()), info.clone());

Let me know if you’d like me to deep-dive into any specific rule!

crates/biome_js_analyze/tests/quick_test.rs (1)

50-56: JSX runtime configuration: good call.

Configuring ReactClassic here is appropriate and keeps this quick test aligned with runtime-sensitive rules.