-
-
Notifications
You must be signed in to change notification settings - Fork 762
feat(cli): verbosity argument #6244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e62c9ef to
8246d8a
Compare
🦋 Changeset detectedLatest commit: 9985303 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8246d8a to
af33ef7
Compare
86b07e3 to
9985303
Compare
arendjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
just having some doubts around the terminology ofverbosity=minimal. Minimal means as little as can be, so effectively a verbosity of none unless absolutely necessary. Printing headers of diagnostics seems to clash with that. Maybe verbosity=headers or verbosity=summary?
| "@biomejs/biome": minor | ||
| --- | ||
|
|
||
| Added a new CLI flag `--minimal` that prints only the header of the diagnostics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks oudated?
|
Actually, I changed my mind. The solution always felt off to me, and it seems we're deprecating stuff just to provide some information we already have. I close this PR, and improve the summary reporter |
Summary
This PR adds a new
--verbosityargument, and closs #6084The
--verbosityargument is going to replace--verbose. The reason I added a new argument that goes in "conflict" with--verboseis because I wanted to avoid having--verboseand--minimal. Plus, with an enum, we can provide more functionality in the future.To replicate
--verbose(which is deprecated, but still available), users will use--verbosity=full.Please bikeshed and provide better names if you see fit.
The new feature is
--verbosity=minimal, which prints minimal diagnostics (only the header).Test Plan
Updated tests, added new diagnostics, added new tests.