try reproducing incorrect coverage when loading querystring #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for convenience, the vanilla directory at the PR is linked here c8火$ tree test/fixtures/all/vanilla/
test/fixtures/all/vanilla/
├── dir
│ └── unloaded.js
├── loaded.js
├── main.js
└── main.querystring-import.mjs
2 directories, 4 files |
|
Experimenting a little big creates a situation that reproduces the error. At this PR, comment-out all other tests in "./test/integration.js" and the coverage error occurs --------------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
--------------|---------|----------|---------|---------|-------------------
All files | 82.14 | 75 | 50 | 82.14 |
vanilla | 100 | 100 | 100 | 100 |
loaded.js | 100 | 100 | 100 | 100 |
main.js | 100 | 100 | 100 | 100 |
vanilla/dir | 0 | 0 | 0 | 0 |
unloaded.js | 0 | 0 | 0 | 0 | 1-5
--------------|---------|----------|---------|---------|------------------- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to reproduce inaccurate coverage results described here #325 cc @koshic @coderaiser @shnhrrsn
update (success): to reproduce the error with this branch, run
npm run test-loaderThe error is not reproduced when all tests run together, as innpm run testso a separatenpm run test-loadercommand is added to reproduce the issue.