Add @babel/types as a dependency of @babel/parser
#16688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Spencer Elliott <[email protected]> Co-authored-by: Mateusz Burzyński <[email protected]> Co-authored-by: merceyz <[email protected]>
853d023 to
d154c71
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57510 |
JLHwung
approved these changes
Jul 29, 2024
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
If we can get rid of the parser's node clone method in Babel 8, we can consider using the babel types node builder to create AST nodes directly, which will make @babel/types a runtime dependency. This approach should be better than our current approach where a blanket node is assigned with random new properties depending on different AST types.
Member
Author
|
I like that currently @babel/parser is a single ESM file with no deps, so it can trivially loaded in browsers, but yes we should think about it. |
liuxingbaoyu
approved these changes
Jul 30, 2024
This was referenced Aug 21, 2024
This was referenced Aug 21, 2024
Open
This was referenced Aug 22, 2024
This was referenced Oct 27, 2024
This was referenced Oct 27, 2024
This was referenced Oct 29, 2024
This was referenced Oct 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Closes #15042, closes #11118, closes #9924
I still dislike the idea of adding a dependency that is only needed for type-checking and not at runtime, but:
@babel/parseralready in v7, but it's broken because of the missing depSo here we are.