Skip to content

Print parens around as expressions on the LHS #16678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolo-ribaudo merged 2 commits into from
Jul 26, 2024
Merged

Print parens around as expressions on the LHS #16678

nicolo-ribaudo merged 2 commits into from
Jul 26, 2024

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 26, 2024

Q                       A
Fixed Issues? Fixes #16676
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator area: typescript i: regression labels Jul 26, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 26, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57457

@JLHwung JLHwung self-requested a review July 26, 2024 13:26
@nicolo-ribaudo nicolo-ribaudo merged commit 4b0f0f2 into babel:main Jul 26, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the as-parens-assign branch July 26, 2024 13:33
This was referenced Aug 16, 2024
Open
Open
@ashly1111111 ashly1111111 mentioned this pull request Aug 16, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Aug 16, 2024
Open
@DevangPatelUK DevangPatelUK mentioned this pull request Aug 16, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Aug 16, 2024
Open
@YinghanFeng YinghanFeng mentioned this pull request Aug 16, 2024
Open
This was referenced Aug 16, 2024
Open
Open
@jamesleesaunders jamesleesaunders mentioned this pull request Aug 16, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Aug 17, 2024
Open
This was referenced Aug 17, 2024
Open
Open
Open
Open
@mdfkbtc mdfkbtc mentioned this pull request Aug 17, 2024
Open
@tiff-es tiff-es mentioned this pull request Aug 17, 2024
Open
@BitcoinOutput BitcoinOutput mentioned this pull request Aug 17, 2024
Open
This was referenced Oct 5, 2024
Open
Open
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 6, 2024
Open
This was referenced Oct 6, 2024
Open
Open
@mdfkbtc mdfkbtc mentioned this pull request Oct 6, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 8, 2024
Open
This was referenced Oct 8, 2024
Open
Open
Open
@paulineribeyre paulineribeyre mentioned this pull request Oct 17, 2024
Closed
This was referenced Oct 24, 2024
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024
Open
This was referenced Oct 25, 2024
Open
Open
@DevangPatelUK DevangPatelUK mentioned this pull request Oct 25, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Oct 26, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 26, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Oct 26, 2024
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees

No one assigned

Labels

area: typescript i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect parantases removal for TSAsExpression on the lhs

4 participants

@nicolo-ribaudo @babel-bot @JLHwung @liuxingbaoyu