Skip to content

Add duplicate-named-capturing-groups-regex to preset-env #16445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolo-ribaudo merged 13 commits into from
Jul 25, 2024
Merged

Add duplicate-named-capturing-groups-regex to preset-env #16445

nicolo-ribaudo merged 13 commits into from
Jul 25, 2024

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 24, 2024 •
edited
Loading

Q                       A
Fixed Issues? Add duplicate-named-capturing-groups-regex to preset-env as the language will be included in ES2025
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link babel/website#2893
Any Dependency Changes?
License MIT
  • Renmae plugin to transform-*
  • Add it to preset-env

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: preset-env labels Apr 24, 2024
@JLHwung JLHwung added this to the v7.25.0 milestone Apr 24, 2024
@JLHwung JLHwung force-pushed the add-duplicate-named-capturing-groups-regex branch from ee6b37a to fb04bfe Compare April 24, 2024 16:53
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 24, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57451

@JLHwung JLHwung force-pushed the add-duplicate-named-capturing-groups-regex branch from fb04bfe to 8290a7e Compare April 24, 2024 16:58
@JLHwung JLHwung force-pushed the add-duplicate-named-capturing-groups-regex branch from 8290a7e to 4daa034 Compare May 29, 2024 03:25
@JLHwung JLHwung marked this pull request as ready for review May 29, 2024 06:11
@JLHwung
Copy link
Contributor Author

JLHwung commented May 29, 2024

The CI error is related. As duplicate-named-capturing-groups-regex requires babel-core 7.19, preset-env will also indirectly require babel-core 7.19+. This case is similar to the class-static-block transform which requires babel-core 7.12 and was added to preset-env in 7.16.

I tend to revise the regression test so that it works for Babel <7.13.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented May 29, 2024

Isn't adding it to minVersions enough (

babel/packages/babel-preset-env/src/available-plugins.ts

Lines 145 to 152 in 8911810

Object.assign(minVersions, {
"bugfix/transform-safari-id-destructuring-collision-in-function-expression":
"7.16.0",
"bugfix/transform-v8-static-class-fields-redefine-readonly": "7.12.0",
"syntax-import-attributes": "7.22.0",
"transform-class-static-block": "7.12.0",
"transform-private-property-in-object": "7.10.0",
});
)?

@JLHwung JLHwung force-pushed the add-duplicate-named-capturing-groups-regex branch from d260d48 to c38ba38 Compare June 1, 2024 04:34
@JLHwung JLHwung mentioned this pull request Jun 2, 2024
Merged
@JLHwung JLHwung force-pushed the add-duplicate-named-capturing-groups-regex branch from c38ba38 to b9b92ec Compare July 5, 2024 15:59
nicolo-ribaudo
nicolo-ribaudo approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you see if rebasing fixes the CI error?

@JLHwung JLHwung force-pushed the add-duplicate-named-capturing-groups-regex branch from a3ca72b to 51af3dd Compare July 13, 2024 01:12
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jul 15, 2024

Could you change https://github.com/babel/babel/blob/3e4723fd07a0ef22039b508ec4da71ce73be1e6e/.github/workflows/reminders.yml to remind us to deprecate the old one?

This was referenced Oct 5, 2024
Open
Open
Open
Open
Open
@rawdaymohamed rawdaymohamed mentioned this pull request Oct 5, 2024
Closed
This was referenced Oct 5, 2024
Open
Open
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 6, 2024
Open
This was referenced Oct 6, 2024
Open
Open
@mdfkbtc mdfkbtc mentioned this pull request Oct 6, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 8, 2024
Open
This was referenced Oct 8, 2024
Open
Open
Open
@paulineribeyre paulineribeyre mentioned this pull request Oct 17, 2024
Closed
This was referenced Oct 24, 2024
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release

Projects

None yet

Milestone

v7.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JLHwung @babel-bot @nicolo-ribaudo @liuxingbaoyu