Add VerifyLowS helper function to ECDSA signature #2463
+56
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoStingelin
left a comment
There was a problem hiding this comment.
It would be good to add unit tests covering the VerifyLowS function.
Introduce a VerifyLowS helper to detect non-canonical high-S ECDSA signatures, along with unit tests.
Author
|
Thanks @GustavoStingelin for the review — tests have been added. |
GustavoStingelin
suggested changes
Dec 23, 2025
GustavoStingelin
left a comment
There was a problem hiding this comment.
Could rename the table test fields to be more readable
| signatureTests := []struct { | ||
| name string | ||
| sig []byte | ||
| isLowS error |
There was a problem hiding this comment.
Suggested change
| isLowS error | |
| wantErr error |
| } | ||
|
|
||
| for _, test := range signatureTests { | ||
| isLowS := VerifyLowS(test.sig) |
There was a problem hiding this comment.
Suggested change
| isLowS := VerifyLowS(test.sig) | |
| err := VerifyLowS(test.sig) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2462
Add VerifyLowS helper function to ECDSA signature. It will be used on lightningnetwork/lnd#10372.