Add a split_pdf function. #1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found this function useful in my own development. It splits a pdf Document (or each pdf in a DocSet) into multiple Documents, where each resulting Document has the specified number of pages, except possibly the last. Both the pdf binary and elements are split.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new utility function, split_pdf, which splits a PDF Document (or each PDF within a DocSet) into multiple Documents containing a specified number of pages, while preserving both the binary and element data.
- Updated logging of missing binary representations with f-strings
- Introduced split_pdf and its corresponding tests in pdf_utils and test_pdf_utils respectively
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/sycamore/sycamore/utils/pdf_utils.py | Adds the split_pdf function with logic to split a PDF document into multiple parts |
| lib/sycamore/sycamore/tests/unit/utils/test_pdf_utils.py | Adds unit tests for split_pdf and its integration with FlatMap |
Comments suppressed due to low confidence (1)
lib/sycamore/sycamore/utils/pdf_utils.py:164
- [nitpick] Consider renaming the variable 'start' to 'start_page' for improved clarity in indicating it represents the starting page number for the current split.
for idx, start in enumerate(range(1, page_count, num_pages)):
HenryL27
approved these changes
May 22, 2025
Collaborator
HenryL27
left a comment
There was a problem hiding this comment.
@Soeb-aryn you were looking for something like this right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this function useful in my own development. It splits a pdf Document (or each pdf in a DocSet) into multiple Documents, where each resulting Document has the specified number of pages, except possibly the last. Both the pdf binary and elements are split.