add default llm_mode to llms #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Lindeman <[email protected]>
Signed-off-by: Henry Lindeman <[email protected]>
eric-anderson
approved these changes
Apr 9, 2025
| kwargs = {"model_name": self.model_name, "cache": self._cache, "default_mode": self._default_mode} | ||
| return deserializer, (kwargs,) | ||
|
|
||
| def default_mode(self) -> LLMMode: |
Collaborator
There was a problem hiding this comment.
I think you can simplify this. Have each subclass pass in default_mode as a parameter to the LLM superclass (already done), and then have the LLM class return self._default_mode always.
lib/sycamore/sycamore/llms/llms.py
Outdated
| """Abstract representation of an LLM instance. and should be subclassed to implement specific LLM providers.""" | ||
|
|
||
| def __init__(self, model_name, cache: Optional[Cache] = None): | ||
| def __init__(self, model_name, cache: Optional[Cache] = None, default_mode: Optional[LLMMode] = None): |
Collaborator
There was a problem hiding this comment.
make default_mode not optional here. You could do = LLMMode.SYNC, but given how few subclasses we have I think it's better to have it be explicit.
Signed-off-by: Henry Lindeman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.