Skip to content

Fix similarity assert condition for LLM Filter #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhruvkaliraman7 merged 3 commits into from
Jan 7, 2025
Merged

Fix similarity assert condition for LLM Filter #1099

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c81789
Fix assert condition to allow similarity_query to be None when scorer…
dhruvkaliraman7 Jan 7, 2025
7bb75e7
Merge remote-tracking branch 'origin/main' into Fix-similarity-bug
dhruvkaliraman7 Jan 7, 2025
00c2b16
Add test
dhruvkaliraman7 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test
  • Loading branch information
@dhruvkaliraman7
dhruvkaliraman7 committed Jan 7, 2025
commit 00c2b1696f93db3c5d593edb3871c3aab7b1ca0b
13 changes: 13 additions & 0 deletions lib/sycamore/sycamore/tests/unit/utils/test_similarity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import pytest
from unittest.mock import Mock
from sycamore.utils.similarity import make_element_sorter_fn


def test_make_element_sorter_fn_no_similarity_query():
sorter_fn = make_element_sorter_fn("test_field", None, Mock())
assert sorter_fn({}) is None


def test_make_element_sorter_fn_no_similarity_scorer():
with pytest.raises(AssertionError, match="Similarity sorting requires a scorer"):
make_element_sorter_fn("test_field", "query", None)
Loading