fix: install autoconf 2.69 by default #427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsirius
reviewed
Jun 29, 2023
Member
starsirius
left a comment
There was a problem hiding this comment.
Do we need that specific 2.69 version? If so, maybe we can add a comment about it!
starsirius
approved these changes
Jun 29, 2023
Member
starsirius
left a comment
There was a problem hiding this comment.
Do we need that specific 2.69 version? If so, maybe we can add a comment about it!
Contributor
Author
|
Yeah, I can put the comment back in and make it more general (ie. not specific to Mojave) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the APRd setup script to install autoconf 2.69 by default. It currently only does it for a specific version of macOS (10.14.6), but I have needed to perform this step manually in subsequent versions as well.
An alternative approach would be to use
is-at-least, but I think that is only available for Zsh: